Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Improve details view #4098

Merged
merged 22 commits into from
Aug 3, 2023
Merged

[FEATURE REQUEST] Improve details view #4098

merged 22 commits into from
Aug 3, 2023

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Jul 12, 2023 •
edited by jesmrec

Related Issues

App: #4092

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

#4092

QA

Reports & improvements

@Aitorbp Aitorbp self-assigned this Jul 12, 2023
@Aitorbp Aitorbp linked an issue Jul 12, 2023 that may be closed by this pull request
[FEATURE REQUEST] Improve details view #4092
Closed
13 tasks
@Aitorbp Aitorbp force-pushed the feature/improve_details_view branch from e8e22e1 to 5686f55 Compare July 24, 2023 10:25
manuelplazaspalacio
manuelplazaspalacio suggested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@manuelplazaspalacio manuelplazaspalacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes here @Aitorbp

owncloudApp/src/androidTest/java/com/owncloud/android/files/details/FileDetailsFragmentTest.kt Outdated Show resolved Hide resolved
...udData/src/test/java/com/owncloud/android/data/file/datasources/OCLocalFileDataSourceTest.kt Outdated Show resolved Hide resolved
owncloudData/src/test/java/com/owncloud/android/data/file/repository/OCFileRepositoryTest.kt Show resolved Hide resolved
...oudApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsViewModel.kt Show resolved Hide resolved
@Aitorbp Aitorbp force-pushed the feature/improve_details_view branch from 1fd21ea to 17fcf9d Compare August 1, 2023 08:59
@manuelplazaspalacio
Copy link
Contributor

LGTM!! 🏆

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 2, 2023

Let's QA this

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 2, 2023 •
edited

(1) [FIXED]

As improvement, as well as the Last Sync date is hidden when its value is 0 (converted in 1/1/1970), same logic should be applied to Modified and Created to avoid such no-meaning date like:

Screenshot 2023-08-02 at 13 02 42

Is this feasible? @Aitorbp

In an hypotetic case that all dates are 0, may remove the separator line too (need to check this)

Pixel 2, Android 11
d670f1a

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 2, 2023 •
edited

(2) [improvement] [WONT FIX HERE]

  • If you open Details of an image view, thumbnail is visible ✅
  • If you open a txt file (also has thumbnail), thumbnail is not visible ❌

is this fixable?

Pixel 2, Android 11
d670f1a

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 2, 2023 •
edited

(3) [FIXED]

  1. Open Details of a big file (100 MB min)
  2. Click on the thumbnail, so the file starts to sync

Current: Blue badge stays for a second in the thumbnail's bottom right corner, and then disappears
Expected: Blue badge is there while the file is being downloaded (same as file list)

Pixel 2, Android 11
d670f1a

@Aitorbp Aitorbp force-pushed the feature/improve_details_view branch from 940821a to 5d58b59 Compare August 2, 2023 16:54
@jesmrec
Copy link
Collaborator

jesmrec commented Aug 3, 2023

(1) and (3) fixed

(2) will not be fixed as a feature that already happens in master and stable

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 3, 2023

Approved on my side.

Ready to go!!

@Aitorbp Aitorbp force-pushed the feature/improve_details_view branch from 858c175 to 1ddc35c Compare August 3, 2023 08:02
@Aitorbp Aitorbp merged commit 1effe0a into master Aug 3, 2023
5 checks passed
@Aitorbp Aitorbp deleted the feature/improve_details_view branch August 3, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelplazaspalacio manuelplazaspalacio manuelplazaspalacio approved these changes

Assignees

@Aitorbp Aitorbp

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Improve details view
3 participants
@Aitorbp @manuelplazaspalacio @jesmrec