Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Support "per app" language change on Android 13+ #4099

Merged
merged 6 commits into from
Jul 27, 2023
Merged

[FEATURE REQUEST] Support "per app" language change on Android 13+ #4099

merged 6 commits into from
Jul 27, 2023

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Jul 13, 2023 •
edited by JuancaG05

Related Issues

App: #4082

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@Aitorbp Aitorbp self-assigned this Jul 13, 2023
@Aitorbp Aitorbp linked an issue Jul 13, 2023 that may be closed by this pull request
[FEATURE REQUEST] Support "per app" language change on Android 13+ #4082
Closed
9 tasks
JuancaG05
JuancaG05 requested changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This will be very useful. I left some suggestions and comments here @Aitorbp 🤠

changelog/unreleased/4082 Outdated Show resolved Hide resolved
owncloudApp/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/xml/locales_config.xml Show resolved Hide resolved
owncloudApp/src/main/res/xml/locales_config.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/xml/locales_config.xml Outdated Show resolved Hide resolved
@Aitorbp Aitorbp requested a review from JuancaG05 July 20, 2023 11:55
JuancaG05
JuancaG05 requested changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last changes here and we'll be ready to go! @Aitorbp

owncloudApp/src/main/res/xml/locales_config.xml Show resolved Hide resolved
@Aitorbp Aitorbp requested a review from JuancaG05 July 21, 2023 12:01
JuancaG05
JuancaG05 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @Aitorbp! 💯

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 24, 2023

A couple of checks:

  • Android 13: Check that ownCloud is an available option in device Settings > System > Languages & input > App Languages
  • Android 13: Check that app could be set up in a different languages by using the new option available in Settings > System > Languages & input > App Languages
  • Android 13: Check that a missing translation in the chosen language is fallen back to the default system language
  • Android < 13: Legacy behaviour: app getting device set up language.

Approved on my side and ready to go!!

@Aitorbp Aitorbp force-pushed the feature/change_language_android13 branch from 6743bf6 to 6b1ccc4 Compare July 27, 2023 10:11
@Aitorbp Aitorbp force-pushed the feature/change_language_android13 branch from 6b1ccc4 to b49862e Compare July 27, 2023 10:15
@Aitorbp Aitorbp merged commit 49201f2 into master Jul 27, 2023
5 checks passed
@Aitorbp Aitorbp deleted the feature/change_language_android13 branch July 27, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

@manuelplazaspalacio manuelplazaspalacio Awaiting requested review from manuelplazaspalacio

Assignees

@Aitorbp Aitorbp

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Support "per app" language change on Android 13+
3 participants
@Aitorbp @jesmrec @JuancaG05