Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Stop authentication flow after account removal if URL is fixed #4106

Merged
merged 6 commits into from
Jul 28, 2023
Merged

[FEATURE REQUEST] Stop authentication flow after account removal if URL is fixed #4106

merged 6 commits into from
Jul 28, 2023

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Jul 20, 2023 •
edited

Related Issues

App: #4067

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@JuancaG05 JuancaG05 self-assigned this Jul 20, 2023
@JuancaG05 JuancaG05 linked an issue Jul 20, 2023 that may be closed by this pull request
[FEATURE REQUEST] Stop authentication flow after account removal if URL is fixed #4067
Closed
8 tasks
@jesmrec
Copy link
Collaborator

jesmrec commented Jul 21, 2023

Some checks:

Browser auth:

  • Remove last account with no default account
  • Remove last account with default account visible
  • Remove last account with default account no visible
  • Edit account -> here, behaviour stays. I think is positive so credentials are edit in browser.

Basic auth:

  • Remove last account with no default account
  • Remove last account with default account visible
  • Remove last account with default account no visible
  • Edit account

@JuancaG05 JuancaG05 force-pushed the feature/stop_auth_flow_url_fixed branch from 2adea46 to c53850a Compare July 24, 2023 12:42
@Aitorbp Aitorbp force-pushed the feature/stop_auth_flow_url_fixed branch from 61ceded to f5daff9 Compare July 27, 2023 10:42
@Aitorbp Aitorbp merged commit beca7b0 into master Jul 28, 2023
5 checks passed
@Aitorbp Aitorbp deleted the feature/stop_auth_flow_url_fixed branch July 28, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesmrec jesmrec jesmrec approved these changes

@manuelplazaspalacio manuelplazaspalacio Awaiting requested review from manuelplazaspalacio

Assignees

@JuancaG05 JuancaG05

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Stop authentication flow after account removal if URL is fixed
3 participants
@JuancaG05 @jesmrec @Aitorbp