[FEATURE REQUEST] Respect app_provider values from capabilities #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aitorbp
force-pushed
the
feature/respect_app_provider_values_from_capabilities
branch
from
1cc3848
to
2a27ce5
Compare
manuelplazaspalacio
suggested changes
Aug 1, 2023
owncloudData/src/main/java/com/owncloud/android/data/appregistry/OCAppRegistryRepository.kt
Outdated
Show resolved
Hide resolved
owncloudData/src/main/java/com/owncloud/android/data/appregistry/OCAppRegistryRepository.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/owncloud/android/data/appregistry/datasources/RemoteAppRegistryDataSource.kt
Outdated
Show resolved
Hide resolved
Aitorbp
force-pushed
the
feature/respect_app_provider_values_from_capabilities
branch
2 times, most recently
from
b85896a
to
b854567
Compare
manuelplazaspalacio
approved these changes
Aug 2, 2023
|
Fixed. Just tested in the attached demo server with different capability value. Let's give a try and get feedback. |
Aitorbp
force-pushed
the
feature/respect_app_provider_values_from_capabilities
branch
from
f35a185
to
5ea3e1b
Compare
Aitorbp
deleted the
feature/respect_app_provider_values_from_capabilities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #4075
Library PR (if needed): owncloud/android-library#577
QA