Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] unneccessary or wrong call .... #4131

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

manuelplazaspalacio
Copy link
Contributor

@manuelplazaspalacio manuelplazaspalacio commented Aug 18, 2023

Related Issues

App: #4074

Library PR (if needed): owncloud/android-library#578

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@manuelplazaspalacio manuelplazaspalacio linked an issue Aug 18, 2023 that may be closed by this pull request
@manuelplazaspalacio manuelplazaspalacio force-pushed the feature/unneccesary_call branch 2 times, most recently from 3576973 to a85600e Compare August 18, 2023 10:01
@manuelplazaspalacio manuelplazaspalacio self-assigned this Aug 18, 2023
Copy link
Contributor

@Aitorbp Aitorbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 21, 2023

(1)

  1. Select any file and Copy or Move
  2. Select destination folder

Current: conflict dialog arises
Expected: correct copy or move operation

Pixel 2 Android 11
2612eba8f

@Aitorbp
Copy link
Contributor

Aitorbp commented Aug 23, 2023

LGTM!!

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 23, 2023

QA checks:

  • Basic auth -> remote.php/dav/files/
  • OAuth2 -> remote.php/dav/files/

Let's go for it.

@manuelplazaspalacio manuelplazaspalacio merged commit 02a321e into master Aug 23, 2023
5 checks passed
@manuelplazaspalacio manuelplazaspalacio deleted the feature/unneccesary_call branch August 23, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] unneccessary or wrong call ....
3 participants