Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] NPE related to MainFileListViewModel #4241

Merged
merged 3 commits into from
Dec 18, 2023
Merged

[BUG] NPE related to MainFileListViewModel #4241

merged 3 commits into from
Dec 18, 2023

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Dec 1, 2023 •
edited

Related Issues

App:#4065

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@Aitorbp Aitorbp self-assigned this Dec 1, 2023
@Aitorbp Aitorbp linked an issue Dec 1, 2023 that may be closed by this pull request
[BUG] NPE related to MainFileListViewModel #4065
Closed
@JuancaG05 JuancaG05 changed the title BUG] NPE related to MainFileListViewModel [BUG] NPE related to MainFileListViewModel Dec 1, 2023
@Aitorbp Aitorbp force-pushed the feature/npe_related_to_mainfilelistviewmodel branch from ff7bc96 to f96c227 Compare December 12, 2023 11:20
@JuancaG05 JuancaG05 self-requested a review December 13, 2023 13:54
JuancaG05
JuancaG05 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Now we'll have to see if this has consequences in case fileById is null and thus parentDir is null 👀

@jesmrec
Copy link
Collaborator

jesmrec commented Dec 14, 2023

Nothing to test here, just waiting for next release. If the crash does not happen anymore, please close the issue then

@JuancaG05 JuancaG05 force-pushed the feature/npe_related_to_mainfilelistviewmodel branch from f96c227 to ba351f1 Compare December 18, 2023 10:00
@JuancaG05 JuancaG05 merged commit afd3489 into master Dec 18, 2023
3 checks passed
@JuancaG05 JuancaG05 deleted the feature/npe_related_to_mainfilelistviewmodel branch December 18, 2023 10:15
Aitorbp pushed a commit that referenced this pull request Feb 5, 2024
@JuancaG05 @Aitorbp
Merge pull request #4241 from owncloud/feature/npe_related_to_mainfil…
159c1ec 
…elistviewmodel

[BUG] NPE related to MainFileListViewModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@Aitorbp Aitorbp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] NPE related to MainFileListViewModel
3 participants
@Aitorbp @jesmrec @JuancaG05