Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle audio focus and becoming noisy #4263

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

parneet-guraya
Copy link
Contributor

@parneet-guraya parneet-guraya commented Dec 18, 2023

  • Handle Audio focus
  • Handle Audio becoming noisy

Handle audio focus -->

The player will handle the audio focus shifts. Basically It would:

  • Pause the already playing media when this player is started.
  • Or If some other media starts this player would pause itself.
    This would avoid two media's playing at the same time.
Record_2023-12-18-06-41-18.mp4

Handle audio becoming noisy -->

When a headset is unplugged or a Bluetooth device disconnected, the audio stream automatically reroutes to the built-in speaker. If you listen to music at a high volume, this can be a noisy surprise.

Users usually expect apps that include a music player with onscreen playback controls to pause playback in this case. Other apps, like games that don't include controls, should keep playing. The user can adjust the volume with the device's hardware controls.

See More

Record_2023-12-18-06-42-25.mp4

You can see here after turning of bluetooth the playback pauses.

@parneet-guraya
Copy link
Contributor Author

Hi @JuancaG05 👋 Could you take a quick look 👀

@JuancaG05 JuancaG05 self-requested a review December 18, 2023 13:02
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @parneet-guraya! LGTM! Simple but nice improvements! Thanks a lot for another contribution! 👍

@jesmrec
Copy link
Collaborator

jesmrec commented Dec 22, 2023

Go ahead!

Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
@JuancaG05 JuancaG05 merged commit c4c2ac6 into owncloud:master Jan 8, 2024
4 checks passed
Aitorbp pushed a commit that referenced this pull request Feb 5, 2024
@jesmrec jesmrec mentioned this pull request Feb 7, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants