Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Unify http log #4266

Merged
merged 4 commits into from
Dec 22, 2023
Merged

[FIX] Unify http log #4266

merged 4 commits into from
Dec 22, 2023

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Dec 18, 2023

Related Issues

App: #4258

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@Aitorbp Aitorbp linked an issue Dec 18, 2023 that may be closed by this pull request
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny changes here for you to review @Aitorbp!

@Aitorbp Aitorbp force-pushed the feature/unify_http_logs branch 6 times, most recently from bf61e96 to 6989eee Compare December 18, 2023 14:09
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Dec 22, 2023

Please, remove from Calens the part of "New log format" because everything new in the logging is already included in an existing Calens entry. Keeping the support for the new format application/jrd+json is enough

@jesmrec
Copy link
Collaborator

jesmrec commented Dec 22, 2023

Approved on my side

@JuancaG05 JuancaG05 merged commit 478f1d5 into master Dec 22, 2023
5 checks passed
@JuancaG05 JuancaG05 deleted the feature/unify_http_logs branch December 22, 2023 14:11
Aitorbp pushed a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify http log
3 participants