Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECHNICAL] Unit tests for repository classes - Part 1 #4281

Merged
merged 9 commits into from
Feb 15, 2024

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Jan 8, 2024

Related Issues

App: #4232

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

@Aitorbp Aitorbp linked an issue Jan 8, 2024 that may be closed by this pull request
8 tasks
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes requested here @Aitorbp, you should pay more attention to previous reviews 😅
Also, in this case calens is not working because the name of the branch is incorrect. Pay attention to these details, they can break our normal workflow

@Aitorbp Aitorbp force-pushed the feature/technical/testing_repositories_1 branch from 92ef3c5 to 7b97e04 Compare February 11, 2024 20:10
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of CR here @Aitorbp

@Aitorbp Aitorbp force-pushed the feature/technical/testing_repositories_1 branch from 742a5d4 to ad521d5 Compare February 14, 2024 13:04
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change here @Aitorbp

@Aitorbp Aitorbp force-pushed the feature/technical/testing_repositories_1 branch from 2c942c4 to 3f1b3ba Compare February 15, 2024 08:49
@Aitorbp Aitorbp force-pushed the feature/technical/testing_repositories_1 branch from 3f1b3ba to 788c051 Compare February 15, 2024 08:50
@Aitorbp Aitorbp force-pushed the feature/technical/testing_repositories_1 branch from 788c051 to 4d58911 Compare February 15, 2024 09:30
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@Aitorbp Aitorbp merged commit 0bc2e1f into master Feb 15, 2024
4 checks passed
@Aitorbp Aitorbp deleted the feature/technical/testing_repositories_1 branch February 15, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Unit tests for repository classes - Part 1
2 participants