Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECHNICAL] Upgrade min SDK to Android 7.0 (v24) #4299

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Jan 26, 2024

Related Issues

App:#4230

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@Aitorbp Aitorbp self-assigned this Jan 26, 2024
@Aitorbp Aitorbp linked an issue Jan 26, 2024 that may be closed by this pull request
7 tasks
@Aitorbp Aitorbp force-pushed the technical/upgrade_min_sdk_to_android_7 branch from 69e1f9e to 5a22381 Compare January 26, 2024 13:43
@Aitorbp Aitorbp force-pushed the technical/upgrade_min_sdk_to_android_7 branch 2 times, most recently from 5a22381 to 14b5ab5 Compare February 15, 2024 08:20
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change here and ready to go! @Aitorbp

Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can safely remove the ShareLinkToDialog.java class as well, since it is not used anymore

@Aitorbp Aitorbp force-pushed the technical/upgrade_min_sdk_to_android_7 branch 2 times, most recently from b29dcc9 to 453e3b4 Compare February 19, 2024 23:04
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 20, 2024

Some basic checks performed: installation, not installation in Android 6 and, video preview and share sheet.

Everything OK from my side to move forward.

@Aitorbp Aitorbp force-pushed the technical/upgrade_min_sdk_to_android_7 branch from b77b5e9 to fd8767b Compare February 20, 2024 11:30
@Aitorbp Aitorbp merged commit 6518649 into master Feb 20, 2024
5 checks passed
@Aitorbp Aitorbp deleted the technical/upgrade_min_sdk_to_android_7 branch February 20, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Upgrade min SDK to Android 7.0 (v24)
3 participants