[FEATURE REQUEST] Manual removal of local storage #4334

Aitorbp · 2024-03-05T08:47:25Z

Related Issues

App: #4174

Add changelog files for the fixed issues in folder changelog/unreleased. More info here
Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

checks performed: #4334 (comment)

Reports:

(1) text overlaps icons [FEATURE REQUEST] Manual removal of local storage #4334 (comment) [FIXED]
(2) Icon election [FEATURE REQUEST] Manual removal of local storage #4334 (comment) [WONT FIX]

JuancaG05

Several things to check here yet @Aitorbp

changelog/unreleased/4334

...udApp/src/main/java/com/owncloud/android/presentation/accounts/AccountsManagementActivity.kt

owncloudApp/src/main/res/values/strings.xml

owncloudData/src/main/java/com/owncloud/android/data/providers/LocalStorageProvider.kt

...java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSourceTest.kt

owncloudDomain/src/main/java/com/owncloud/android/domain/files/FileRepository.kt

owncloudData/src/test/java/com/owncloud/android/data/files/repository/OCFileRepositoryTest.kt

owncloudData/src/main/java/com/owncloud/android/data/files/db/FileDao.kt

owncloudData/src/main/java/com/owncloud/android/data/providers/LocalStorageProvider.kt

...java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSourceTest.kt

JuancaG05

Some more changes and ready to go @Aitorbp

JuancaG05 · 2024-03-27T09:50:56Z

owncloudData/src/test/java/com/owncloud/android/data/files/repository/OCFileRepositoryTest.kt

+    @Test
+    fun `getDownloadedFilesForAccount returns an empty list when datasource returns an empty list`() {
+        every { localFileDataSource.getDownloadedFilesForAccount(OC_ACCOUNT_NAME) } returns emptyList()
+
+        val result = ocFileRepository.getDownloadedFilesForAccount(OC_ACCOUNT_NAME)
+
+        assertEquals(emptyList<OCFile>(), result)
+
+        verify(exactly = 1) { localFileDataSource.getDownloadedFilesForAccount(OC_ACCOUNT_NAME) }
+    }


This is not needed, the result is what the datasource returns, we're not giving it a special treatment in-between

Ok, deleted

JuancaG05

LGTM 👍

jesmrec · 2024-04-01T08:06:14Z

Let's QA this one...

jesmrec · 2024-04-01T08:07:44Z

QA checks:

jesmrec · 2024-04-01T08:09:55Z

(1) [FIXED]

We have lost the layout adaption for long strings. Is this a regression?:

Pixel 2, Android 11
725873470

jesmrec · 2024-04-01T08:16:53Z

(2) [WONT FIX]

i don't want to look crazy, but the new icon looks like a brush more than a broom, not sure how clear it will be for users. This is how it looks like, any better idea @tbsbdr?:

tbsbdr · 2024-04-03T16:52:37Z

as suggested by you: lets stick to the icon you suggested for now and show a dialog to that the user gets reassured within the text dialog, what will happen if he/she proceeds.

my perspective is, this icon is just a temporary solution because we don't have a better one as of now.

For the future, I can also think about using a "drawer menu" like you suggested and already made for files. This could be a better way to add more actions because we can fit more in it. In a drawer, we can also put in some text to explain what the icons mean.

Drawer example from material design

jesmrec · 2024-04-04T06:19:09Z

So, the brush-broom icon will be the first approach. We'll work in future improvements

jesmrec · 2024-04-04T06:59:21Z

Approved on my side

…Source

…ilesForAccount function

…ity, listener in AccountsManagementAdapter and cleanAccount function with the use case

…ions/variables, refactor classes and changes xml

Aitorbp self-assigned this Mar 5, 2024

Aitorbp linked an issue Mar 5, 2024 that may be closed by this pull request

[FEATURE REQUEST] Manual removal of local storage #4174

Closed

15 tasks

Aitorbp requested a review from JuancaG05 March 5, 2024 09:24

Aitorbp force-pushed the feature/manual_removal_local_storage branch 2 times, most recently from c5ffe1a to ec30fb5 Compare March 26, 2024 09:17

JuancaG05 requested changes Mar 26, 2024

View reviewed changes

Aitorbp force-pushed the feature/manual_removal_local_storage branch from b05ec0d to 3698f48 Compare March 26, 2024 18:45

JuancaG05 reviewed Mar 27, 2024

View reviewed changes

JuancaG05 requested changes Mar 27, 2024

View reviewed changes

Aitorbp requested a review from JuancaG05 March 27, 2024 10:13

JuancaG05 approved these changes Mar 27, 2024

View reviewed changes

jesmrec added the Approved by qa label Apr 4, 2024

Aitorbp force-pushed the feature/manual_removal_local_storage branch from bd88dcc to 7650be0 Compare April 5, 2024 06:38

Aitorbp added 10 commits April 5, 2024 08:11

Added getFilesForAccount in FileDao, FileRepository and LocalFileData…

fa37d6e

…Source

Added usecase RemoveFilesForAccountUseCase and created clearTemporalF…

fc69541

…ilesForAccount function

Added clean icon, dialog and subscriptions in AccountsManagementActiv…

b41c02b

…ity, listener in AccountsManagementAdapter and cleanAccount function with the use case

Added tests in OCFileRepositoryTest and OCLocalFileDataSourceTest

0733b3b

Added release notes and some strings related to dialog

15ab24e

feat: removed clearTemporalFilesForAccount func

50a0f6e

feat: Changed release note

95fc49c

feat: Reorder functions in OCLocalFileDataSource

6320491

fix: Changes in strings of release notes and clean_data_account_message

e515f9a

fix: Improve the SELECT_FILES_FOR_ACCOUNT, changed named of the funct…

de1d04d

…ions/variables, refactor classes and changes xml

Aitorbp and others added 5 commits April 5, 2024 08:11

fix: Changes in tests

424589b

chore: Added calens

c3ef195

docs: calens changelog updated

7c0aed5

fix: changed name in dao, removed test and author in header

928ad18

fix: changed the constrain of textview account

762ab03

Aitorbp force-pushed the feature/manual_removal_local_storage branch from 7650be0 to 762ab03 Compare April 5, 2024 07:11

Aitorbp merged commit e1cf321 into master Apr 5, 2024
6 checks passed

Aitorbp deleted the feature/manual_removal_local_storage branch April 5, 2024 07:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE REQUEST] Manual removal of local storage #4334

[FEATURE REQUEST] Manual removal of local storage #4334

Aitorbp commented Mar 5, 2024 •

edited by jesmrec

JuancaG05 left a comment

JuancaG05 left a comment

JuancaG05 Mar 27, 2024

Aitorbp Mar 27, 2024

JuancaG05 left a comment

jesmrec commented Apr 1, 2024

jesmrec commented Apr 1, 2024 •

edited

jesmrec commented Apr 1, 2024 •

edited

jesmrec commented Apr 1, 2024 •

edited

tbsbdr commented Apr 3, 2024 •

edited

jesmrec commented Apr 4, 2024

jesmrec commented Apr 4, 2024

[FEATURE REQUEST] Manual removal of local storage #4334

[FEATURE REQUEST] Manual removal of local storage #4334

Conversation

Aitorbp commented Mar 5, 2024 • edited by jesmrec

Related Issues

QA

JuancaG05 left a comment

Choose a reason for hiding this comment

JuancaG05 left a comment

Choose a reason for hiding this comment

JuancaG05 Mar 27, 2024

Choose a reason for hiding this comment

Aitorbp Mar 27, 2024

Choose a reason for hiding this comment

JuancaG05 left a comment

Choose a reason for hiding this comment

jesmrec commented Apr 1, 2024

jesmrec commented Apr 1, 2024 • edited

jesmrec commented Apr 1, 2024 • edited

(1) [FIXED]

jesmrec commented Apr 1, 2024 • edited

(2) [WONT FIX]

tbsbdr commented Apr 3, 2024 • edited

Drawer example from material design

jesmrec commented Apr 4, 2024

jesmrec commented Apr 4, 2024

Aitorbp commented Mar 5, 2024 •

edited by jesmrec

jesmrec commented Apr 1, 2024 •

edited

jesmrec commented Apr 1, 2024 •

edited

jesmrec commented Apr 1, 2024 •

edited

tbsbdr commented Apr 3, 2024 •

edited