Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add search functionality to spaces list #4393

Merged
merged 9 commits into from
Apr 30, 2024

Conversation

joragua
Copy link
Collaborator

@joragua joragua commented Apr 24, 2024

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua changed the title [FEATURE] Add search functionality to spaces list [FEATURE REQUEST] Add search functionality to spaces list Apr 24, 2024
@joragua joragua linked an issue Apr 24, 2024 that may be closed by this pull request
10 tasks
@joragua joragua force-pushed the feature/search_functionality_in_spaces_list branch 2 times, most recently from 8b12a41 to fc4e5ab Compare April 24, 2024 12:07
@joragua joragua requested a review from JuancaG05 April 24, 2024 12:08
@joragua joragua marked this pull request as ready for review April 24, 2024 12:09
@joragua joragua force-pushed the feature/search_functionality_in_spaces_list branch from 495cca9 to d711541 Compare April 25, 2024 07:51
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job here @joragua! Some comments here 😸

@joragua joragua force-pushed the feature/search_functionality_in_spaces_list branch from c6f15e3 to c08eb85 Compare April 26, 2024 09:45
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 29, 2024

The calens entry of the current PR should overwrite the entry #4311. With the work done here, that other one is out of scope and its meaning is the opposite.

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 29, 2024

QA checks:

  • List of spaces -> Personal never there.
  • Folder picker in Copy operation -> Personal always there.
  • Camera uploads picker -> Personal always there.
  • Share from 3rd party app picker -> Personal always there.

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 29, 2024

I noticed that the spaces' thumbnails mixed after closing the searching option. Something related with recycler list?

Given the following list of spaces in server:

Screenshot 2024-04-29 at 14 46 09

Check the following videos out:

Screen_recording_20240429_144644.mp4
Screen_recording_20240429_144859.mp4

first video: the space called New space show a repeated thumbnail, whereas it doesn't have any thumbnail
second video: the space called New space show a repeated thumbnail, whereas it doesn't have any thumbnail

it's like a glitch that can create some hassle

could you take a look?

@joragua
Copy link
Collaborator Author

joragua commented Apr 30, 2024

The problem was that the image of New space couldn't load correctly because it was setting the image of the space that it was previously in the same position in RecyclerView. The solution here is reset the element with dispose() before setting the default image. I've fixed it and now it should work. ✅

Also I removed calens file about #4311

@joragua joragua self-assigned this Apr 30, 2024
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 30, 2024

Glitch is fixed. This is ready to go 🚀

@joragua joragua force-pushed the feature/search_functionality_in_spaces_list branch from 39794e8 to f4ebd56 Compare April 30, 2024 12:26
@joragua joragua merged commit 4c7a1e9 into master Apr 30, 2024
3 checks passed
@joragua joragua deleted the feature/search_functionality_in_spaces_list branch April 30, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPACES] Add search functionality to spaces list
3 participants