-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Add search functionality to spaces list #4393
Conversation
8b12a41
to
fc4e5ab
Compare
495cca9
to
d711541
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job here @joragua! Some comments here 😸
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt
Show resolved
Hide resolved
c6f15e3
to
c08eb85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
The calens entry of the current PR should overwrite the entry #4311. With the work done here, that other one is out of scope and its meaning is the opposite. |
QA checks:
|
I noticed that the spaces' thumbnails mixed after closing the searching option. Something related with recycler list? Given the following list of spaces in server: Check the following videos out: Screen_recording_20240429_144644.mp4Screen_recording_20240429_144859.mp4first video: the space called it's like a glitch that can create some hassle could you take a look? |
The problem was that the image of Also I removed calens file about #4311 |
Glitch is fixed. This is ready to go 🚀 |
39794e8
to
f4ebd56
Compare
Related Issues
App:
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA