Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Can't stream video from space #4394

Merged
merged 4 commits into from
Apr 30, 2024
Merged

[BUG] Can't stream video from space #4394

merged 4 commits into from
Apr 30, 2024

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Apr 30, 2024 •
edited

Related Issues

App: #4328

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@JuancaG05 JuancaG05 requested a review from Aitorbp April 30, 2024 08:07
@JuancaG05 JuancaG05 self-assigned this Apr 30, 2024
Aitorbp
Aitorbp requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@Aitorbp Aitorbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything all right. Just one tiny change, please, update the License in PrepareVideoPlayerAsyncTask and ready to go.

@JuancaG05
Copy link
Collaborator Author

@Aitorbp I didn't update it because there are no authors figuring right now, so it's better to keep it like that (I hope it will be moved to Kotlin soon)

@Aitorbp
Copy link
Contributor

Aitorbp commented Apr 30, 2024

@Aitorbp I didn't update it because there are no authors figuring right now, so it's better to keep it like that (I hope it will be moved to Kotlin soon)

Ok, LGTM

@Aitorbp Aitorbp linked an issue Apr 30, 2024 that may be closed by this pull request
[BUG] Can't stream video from space #4328
Closed
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 30, 2024

QA checks

  1. oCIS

Streaming:

  • Video in root of Personal
  • Video in non-root of Personal
  • Video in root of non-Personal
  • Video in non-root of non-Personal

Locally downloaded:

  • Video in root of Personal
  • Video in non-root of Personal
  • Video in root of non-Personal
  • Video in non-root of non-Personal
  1. oC10

Streaming:

  • Video in root
  • Video in non-root

Locally downloaded:

  • Video in root
  • Video in non-root

Everything OK ✅

@JuancaG05 JuancaG05 force-pushed the fix/video_streaming_in_spaces branch from be5cb6d to ad26ec1 Compare April 30, 2024 13:06
@jesmrec jesmrec merged commit bc5c42f into master Apr 30, 2024
3 checks passed
@jesmrec jesmrec deleted the fix/video_streaming_in_spaces branch April 30, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aitorbp Aitorbp Aitorbp approved these changes

Assignees

@JuancaG05 JuancaG05

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Can't stream video from space
3 participants
@JuancaG05 @Aitorbp @jesmrec