implement WebCal support #694

georgehrke · 2016-08-10T20:31:46Z

No description provided.

mention-bot · 2016-08-10T20:31:48Z

@georgehrke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @raghunayyar, @tcitworld and @raimund-schluessler to be potential reviewers

phsc84 · 2016-08-10T21:20:50Z

I'm just curious: What's the difference to #631?

georgehrke · 2016-08-10T21:24:30Z

It uses a different approach.
#631 caches the ics files on the server. I'm not really happy with that approach.
This branch handles all of this in the user's browser.
It also reuses lots of code from #631 though.

coveralls · 2016-08-11T12:20:21Z

Coverage decreased (-0.4%) to 23.709% when pulling 97b0f83 on feature/webcal into 9e62f7a on master.

georgehrke · 2016-08-11T12:33:17Z

proper error handling
tests

~~[ ] web-based protocol handlers~~

coveralls · 2016-08-11T12:33:17Z

Coverage decreased (-0.4%) to 23.709% when pulling 351c6d7 on feature/webcal into 9e62f7a on master.

coveralls · 2016-08-11T12:41:49Z

Coverage decreased (-0.4%) to 23.709% when pulling efc5d21 on feature/webcal into 9e62f7a on master.

tcitworld · 2016-08-11T13:34:24Z

js/app/models/webcalModel.js

+	function WebCal(url, props) {
+		const context = {};
+
+		if (props.href.startsWith('webcal://')) {


Is this needed anymore with WebCalUtility ?

No, it is yet to be replaced

tcitworld · 2016-08-11T13:57:15Z

As of now, remote calendars are not cached, correct ?

EDIT : Inside the browser, I mean.

coveralls · 2016-08-11T14:00:09Z

Coverage decreased (-0.4%) to 23.75% when pulling 08fb48b on feature/webcal into 9e62f7a on master.

georgehrke · 2016-08-11T14:00:12Z

Exactly, it's not cached in the browser. That's what this ticket is about: #364

(We store it in the WebCalService though. When you change month it doesn't query the webcal file again)

coveralls · 2016-08-11T17:03:38Z

Coverage decreased (-0.4%) to 23.752% when pulling 6abcafd on feature/webcal into 9e62f7a on master.

georgehrke · 2016-08-11T17:13:45Z

fix download link to webcal calendars

coveralls · 2016-08-11T17:14:35Z

Coverage decreased (-0.4%) to 23.752% when pulling 7b76fd9 on feature/webcal into 11f3f6a on master.

tcitworld · 2016-08-12T09:06:24Z

http/StreamResponse.php

+	/**
+	 * @param IOutput $output a small wrapper that handles output
+	 */
+	public function callback (IOutput $output) {


What about if someone provides a huge file ?

That's why I decided to use streams. 😉

georgehrke · 2016-08-12T10:19:32Z

webcals is not a thing. When URL is stored as webcal try https first and fall back to http

georgehrke · 2016-09-14T21:42:14Z

Let's do the web-based protocol handlers thing in a follow up pr. This pr is already huge

georgehrke · 2016-09-14T21:44:15Z

protocol handlers: #742

georgehrke · 2016-09-14T21:45:01Z

the 301 thing: #743

georgehrke · 2016-09-15T10:56:37Z

There is only one thing left:

fix js unit tests

georgehrke · 2016-09-15T13:33:54Z

@tcitworld I think this can go in. What do you think?

coveralls · 2016-09-15T13:44:50Z

Coverage increased (+0.6%) to 25.782% when pulling 1094a56 on feature/webcal into fd0c66b on master.

tcitworld · 2016-09-15T13:45:24Z

I didn't test your last changes, but it should be good.

georgehrke · 2016-09-15T13:46:01Z

okay :)
Let's get this in!

tcitworld · 2016-09-15T14:13:43Z

I'm getting php notice messages like rewind(): stream does not support seeking so this line might now be needed (see http://stackoverflow.com/a/6518288).

georgehrke · 2016-09-15T14:34:52Z

Hm, okay. I guess we can just remove the rewind after all

georgehrke added the 2 - developing label Aug 10, 2016

georgehrke force-pushed the feature/webcal branch from 50a96b7 to 7e34f4f Compare August 10, 2016 21:10

georgehrke force-pushed the feature/webcal branch 6 times, most recently from e4ccb28 to 97b0f83 Compare August 11, 2016 12:16

georgehrke force-pushed the feature/webcal branch from 97b0f83 to 351c6d7 Compare August 11, 2016 12:30

georgehrke force-pushed the feature/webcal branch from 351c6d7 to efc5d21 Compare August 11, 2016 12:34

tcitworld reviewed Aug 11, 2016
View reviewed changes

georgehrke force-pushed the feature/webcal branch from efc5d21 to 08fb48b Compare August 11, 2016 13:54

georgehrke force-pushed the feature/webcal branch from 08fb48b to 6abcafd Compare August 11, 2016 16:59

georgehrke force-pushed the feature/webcal branch from 6abcafd to 7b76fd9 Compare August 11, 2016 17:10

tcitworld reviewed Aug 12, 2016
View reviewed changes

georgehrke force-pushed the feature/webcal branch from 7b76fd9 to b3a9344 Compare August 12, 2016 19:55

georgehrke and others added 9 commits September 14, 2016 18:42

SplitterService is now ICalSplitterUtility

7c3a1b9

webcal related fixes

11acef9

more fixes

ad9bd81

fix display of events editor dialog for webcal events

6ee55b3

lock input after creating subscription

1e989c9

php unit tests

69a6b10

pass remote server error code through stream response

4abb772

fixes for some tests, still failing

47bba76

remove wrong content type from json response

63221bb

georgehrke force-pushed the feature/webcal branch from 154ec37 to 63221bb Compare September 14, 2016 16:43

show webcal url

693af89

georgehrke added 2 commits September 15, 2016 12:39

remove web protocol handler for now

c4ca02d

add unit test for Guzzle exception

0309277

georgehrke added 2 commits September 15, 2016 15:32

fix js unit tests

7c866b1

add http folder to Makefile

1094a56

georgehrke added 3 - to review and removed 2 - developing labels Sep 15, 2016

georgehrke merged commit ba67b47 into master Sep 15, 2016

georgehrke deleted the feature/webcal branch September 15, 2016 13:46

georgehrke mentioned this pull request Sep 15, 2016

support for webcal #132

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement WebCal support #694

implement WebCal support #694

georgehrke commented Aug 10, 2016

mention-bot commented Aug 10, 2016

phsc84 commented Aug 10, 2016

georgehrke commented Aug 10, 2016

coveralls commented Aug 11, 2016 •

edited

Loading

georgehrke commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

tcitworld Aug 11, 2016

georgehrke Aug 11, 2016

tcitworld commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

georgehrke commented Aug 11, 2016

coveralls commented Aug 11, 2016 •

edited

Loading

georgehrke commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

tcitworld Aug 12, 2016

georgehrke Aug 12, 2016

georgehrke commented Aug 12, 2016 •

edited

Loading

georgehrke commented Sep 14, 2016

georgehrke commented Sep 14, 2016 •

edited

Loading

georgehrke commented Sep 14, 2016

georgehrke commented Sep 15, 2016 •

edited

Loading

georgehrke commented Sep 15, 2016

coveralls commented Sep 15, 2016 •

edited

Loading

tcitworld commented Sep 15, 2016

georgehrke commented Sep 15, 2016

tcitworld commented Sep 15, 2016 •

edited

Loading

georgehrke commented Sep 15, 2016

implement WebCal support #694

implement WebCal support #694

Conversation

georgehrke commented Aug 10, 2016

mention-bot commented Aug 10, 2016

phsc84 commented Aug 10, 2016

georgehrke commented Aug 10, 2016

coveralls commented Aug 11, 2016 • edited Loading

georgehrke commented Aug 11, 2016 • edited Loading

coveralls commented Aug 11, 2016 • edited Loading

coveralls commented Aug 11, 2016 • edited Loading

tcitworld Aug 11, 2016

Choose a reason for hiding this comment

georgehrke Aug 11, 2016

Choose a reason for hiding this comment

tcitworld commented Aug 11, 2016 • edited Loading

coveralls commented Aug 11, 2016 • edited Loading

georgehrke commented Aug 11, 2016

coveralls commented Aug 11, 2016 • edited Loading

georgehrke commented Aug 11, 2016 • edited Loading

coveralls commented Aug 11, 2016 • edited Loading

tcitworld Aug 12, 2016

Choose a reason for hiding this comment

georgehrke Aug 12, 2016

Choose a reason for hiding this comment

georgehrke commented Aug 12, 2016 • edited Loading

georgehrke commented Sep 14, 2016

georgehrke commented Sep 14, 2016 • edited Loading

georgehrke commented Sep 14, 2016

georgehrke commented Sep 15, 2016 • edited Loading

georgehrke commented Sep 15, 2016

coveralls commented Sep 15, 2016 • edited Loading

tcitworld commented Sep 15, 2016

georgehrke commented Sep 15, 2016

tcitworld commented Sep 15, 2016 • edited Loading

georgehrke commented Sep 15, 2016

coveralls commented Aug 11, 2016 •

edited

Loading

georgehrke commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

tcitworld commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

georgehrke commented Aug 11, 2016 •

edited

Loading

coveralls commented Aug 11, 2016 •

edited

Loading

georgehrke commented Aug 12, 2016 •

edited

Loading

georgehrke commented Sep 14, 2016 •

edited

Loading

georgehrke commented Sep 15, 2016 •

edited

Loading

coveralls commented Sep 15, 2016 •

edited

Loading

tcitworld commented Sep 15, 2016 •

edited

Loading