-
Notifications
You must be signed in to change notification settings - Fork 667
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Poll interval from capabilities (#8777)
* Add remotePollInterval capability. * Use public const int rather than define for default value. * Honour pollinterval from account capabilities for poll frequency. With this, admins can change the remote poll interval of desktop clients with the capability settings. * Use more efficient invocation of the etag job slot. * Consider capability value to be in milliseconds. * Make format check happy. * Add a ElapsedTimer to measure time since last Etag check. Also, do the check if one of the folders is due to sync every second. That way we get a more accurate sync frequency. The check is very lightweight. * Extend remotePollInterval config method to accept default value. With that it is possible to read the value for the remotepollinterval from the capabilities. * Add changelog entry for #8777. * Changes from clang-format * Fix changelog entry, punctuation at end. * do not go for assumptions how long the request takes. No magic number. * Change some method interfaces to seconds rather than microseconds. Feedback from review. * Again considering more review feedback * Remove additional 5s check already performed in ConfigFile::remotePollInterval Co-authored-by: Hannah von Reth <hannah.vonreth@owncloud.com>
- Loading branch information
1 parent
49b415b
commit a668053
Showing
9 changed files
with
78 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Enhancement: Consider a remote poll interval coming with the server capabilities | ||
|
||
This way, admins can configure the remote sync poll interval of clients through | ||
the capabilities settings of the server. Note that the setting in the server | ||
capabilities needs to be done in milliseconds. Default is 30 seconds. | ||
|
||
https://github.com/owncloud/client/issues/5947 | ||
https://github.com/owncloud/client/issues/8780 | ||
https://github.com/owncloud/client/pull/8777 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters