Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --cmd parameter to main UI executable #10976

Closed
2 tasks done
fmoc opened this issue Jun 27, 2023 · 4 comments · Fixed by #11063 or #11076
Closed
2 tasks done

Add --cmd parameter to main UI executable #10976

fmoc opened this issue Jun 27, 2023 · 4 comments · Fixed by #11063 or #11076
Assignees
Labels
p3-medium Normal priority
Milestone

Comments

@fmoc
Copy link
Contributor

fmoc commented Jun 27, 2023

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Feature description

Continuation #10888.

Instead of using the AppRun AppImage entrypoint to provide a --cmd parameter to launch the commandline application (and thus provide an AppImage-only solution), the main UI should receive a --cmd parameter. This way, we provide a unified user experience in all of our distributions.

Proposed solution

--cmd should launch the commandline application (ideally with exec*, otherwise a subprocess might do as well). We need to make sure that --cmd is the first argument passed to the application (i.e., make it position sensitive).

Alternative solutions you considered

No response

Additional context

No response

@fmoc fmoc added this to the Desktop Client 5.0 milestone Jun 27, 2023
@michaelstingl michaelstingl added the p3-medium Normal priority label Jun 27, 2023
TheOneRing added a commit that referenced this issue Jul 25, 2023
@TheOneRing TheOneRing linked a pull request Jul 25, 2023 that will close this issue
TheOneRing added a commit that referenced this issue Jul 28, 2023
TheOneRing added a commit that referenced this issue Jul 28, 2023
@saw-jan
Copy link
Member

saw-jan commented Aug 1, 2023

Tested with ownCloud ownCloud 5.0.0.11624-daily20230801

owncloud appImage ✔️

./ownCloud-5.0.0.11624-daily20230801-x86_64.AppImage --cmd --help
output
m_crashReporterChar:  /tmp/.mount_ownCloKNfR0j/usr/bin/owncloud_crash_reporter
Usage: /tmp/.mount_ownCloKNfR0j/usr/bin/owncloudcmd [options] source_dir server_url remote_folder
owncloudcmd version 5.0.0.11624-daily20230801 - command line client tool

Options:
  -s, --silent                      Don't be so verbose.
  --httpproxy <http://server:port>  Specify a http proxy to use.
  --trust                           Trust the SSL certification
  --exclude <file>                  Path to an exclude list [file]
  --unsyncedfolders <file>          File containing the list of unsynced remote
                                    folders (selective sync)
  --server <url>                    Use [url] as the location of the server.
                                    OCIS only (server location and spaces url
                                    can differ)
  -u, --user <name>                 Use [name] as the login name
  -p, --password <password>         Use [pass] as password
  --non-interactive                 Do not block execution with interaction
  --max-sync-retries <n>            Retries maximum n times (default to 3)
  --uplimit <n>                     Limit the upload speed of files to n KB/s
  --downlimit <n>                   Limit the download speed of files to n KB/s
  --sync-hidden-files               Enables synchronization of hidden files
  --logdebug                        More verbose logging
  -h, --help                        Displays help on commandline options.
  --help-all                        Displays help including Qt specific
                                    options.
  -v, --version                     Displays version information.

Arguments:
  source_dir                        The source dir
  server_url                        The url to the server
  remote_folder                     A remote folder

owncloud gui ✔️

owncloud --cmd --help
output
m_crashReporterChar:  /opt/owncloud.AppDir/usr/bin/owncloud_crash_reporter
Usage: /opt/owncloud.AppDir/usr/bin/owncloudcmd [options] source_dir server_url remote_folder
owncloudcmd version 5.0.0.11624-daily20230801 - command line client tool

Options:
  -s, --silent                      Don't be so verbose.
  --httpproxy <http://server:port>  Specify a http proxy to use.
  --trust                           Trust the SSL certification
  --exclude <file>                  Path to an exclude list [file]
  --unsyncedfolders <file>          File containing the list of unsynced remote
                                    folders (selective sync)
  --server <url>                    Use [url] as the location of the server.
                                    OCIS only (server location and spaces url
                                    can differ)
  -u, --user <name>                 Use [name] as the login name
  -p, --password <password>         Use [pass] as password
  --non-interactive                 Do not block execution with interaction
  --max-sync-retries <n>            Retries maximum n times (default to 3)
  --uplimit <n>                     Limit the upload speed of files to n KB/s
  --downlimit <n>                   Limit the download speed of files to n KB/s
  --sync-hidden-files               Enables synchronization of hidden files
  --logdebug                        More verbose logging
  -h, --help                        Displays help on commandline options.
  --help-all                        Displays help including Qt specific
                                    options.
  -v, --version                     Displays version information.

Arguments:
  source_dir                        The source dir
  server_url                        The url to the server
  remote_folder                     A remote folder

@saw-jan
Copy link
Member

saw-jan commented Aug 1, 2023

owncloud.exe ❌

./owncloud.exe --cmd --help

❗ gives nothing but opens a terminal which gets closed after sometime

CC @TheOneRing

@TheOneRing
Copy link
Member

The client was crashing during startup, even before the crash reporter was set up.
Please try again once #11076 was merged.

@TheOneRing TheOneRing linked a pull request Aug 2, 2023 that will close this issue
@saw-jan
Copy link
Member

saw-jan commented Aug 3, 2023

Tested with ownCloud 5.0.0.11640-daily20230803

owncloud.exe ✔️

Screenshot from 2023-08-03 11-39-33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-medium Normal priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants