Wizard: Crash during shutdown

[TheOneRing]

If the client is terminated while the wizard is open (tested with test\manual\windows close event) the client crashes as it ties to access the
ocApp()->gui()->settingsDialog() which is already destroyed.

client/src/gui/newwizard/setupwizardwindow.cpp

Line 130 in 932ff16

ownCloudGui::raiseDialog(this);

OCC::ownCloudGui::settingsDialog() owncloudgui.cpp:400
OCC::ownCloudGui::raiseDialog(QWidget *) owncloudgui.cpp:986
OCC::Wizard::SetupWizardWindow::displayPage(OCC::Wizard::AbstractSetupWizardPage *, SetupWizardState) setupwizardwindow.cpp:130
OCC::Wizard::SetupWizardController::changeStateTo(SetupWizardState) setupwizardcontroller.cpp:213
`OCC::Wizard::SetupWizardController::changeStateTo'::`2'::<lambda_2>::operator()(const QString &) setupwizardcontroller.cpp:210
QtPrivate::FunctorCall<QtPrivate::IndexesList<0>,QtPrivate::List<QString>,void,`OCC::Wizard::SetupWizardController::changeStateTo'::`2'::<lambda_2> >::call(<lambda_2> &,void **) qobjectdefs_impl.h:127
QtPrivate::Functor<`OCC::Wizard::SetupWizardController::changeStateTo'::`2'::<lambda_2>,1>::call<QtPrivate::List<QString>,void>(<lambda_2> &,void *,void **) qobjectdefs_impl.h:241
QtPrivate::QFunctorSlotObject<`OCC::Wizard::SetupWizardController::changeStateTo'::`2'::<lambda_2>,1,QtPrivate::List<QString>,void>::impl(int,QtPrivate::QSlotObjectBase *,QObject *,void **,bool *) qobjectdefs_impl.h:408
<unknown> 0x00007ff95bf070c3
<unknown> 0x00007ff95bfa8f48
<unknown> 0x00007ff95bf90a28
OCC::Wizard::AbstractSetupWizardState::evaluationFailed(QString) moc_abstractsetupwizardstate.cpp:168
```OCC::Wizard::ServerUrlSetupWizardState::evaluatePage'::`2'::<lambda_3>::operator()'::`2'::<lambda_1>::operator()'::`5'::<lambda_1>::operator()() serverurlsetupwizardstate.cpp:123
QtPrivate::FunctorCall<QtPrivate::IndexesList<>,QtPrivate::List<>,void,```OCC::Wizard::ServerUrlSetupWizardState::evaluatePage'::`2'::<lambda_3>::operator()'::`2'::<lambda_1>::operator()'::`5'::<lambda_1> >::call(<lambda_1> &,void **) qobjectdefs_impl.h:127
QtPrivate::Functor<```OCC::Wizard::ServerUrlSetupWizardState::evaluatePage'::`2'::<lambda_3>::operator()'::`2'::<lambda_1>::operator()'::`5'::<lambda_1>,0>::call<QtPrivate::List<>,void>(<lambda_1> &,void *,void **) qobjectdefs_impl.h:241
QtPrivate::QFunctorSlotObject<```OCC::Wizard::ServerUrlSetupWizardState::evaluatePage'::`2'::<lambda_3>::operator()'::`2'::<lambda_1>::operator()'::`5'::<lambda_1>,0,QtPrivate::List<>,void>::impl(int,QtPrivate::QSlotObjectBase *,QObject *,void **,bool *) qobjectdefs_impl.h:408
<unknown> 0x00007ff95bf070c3
<unknown> 0x00007ff95bfa8f48
<unknown> 0x00007ff95bf90a28
OCC::CoreJob::finished() moc_abstractcorejob.cpp:175
OCC::CoreJob::setError(const QString &) abstractcorejob.cpp:80
OCC::AbstractCoreJobFactory::setJobError(OCC::CoreJob *, const QString &) abstractcorejob.cpp:41
``OCC::Wizard::Jobs::ResolveUrlJobFactory::startJob'::`2'::<lambda_2>::operator()'::`2'::<lambda_2>::operator()() resolveurljobfactory.cpp:114
QtPrivate::FunctorCall<QtPrivate::IndexesList<>,QtPrivate::List<>,void,``OCC::Wizard::Jobs::ResolveUrlJobFactory::startJob'::`2'::<lambda_2>::operator()'::`2'::<lambda_2> >::call(<lambda_2> &,void **) qobjectdefs_impl.h:127
QtPrivate::Functor<``OCC::Wizard::Jobs::ResolveUrlJobFactory::startJob'::`2'::<lambda_2>::operator()'::`2'::<lambda_2>,0>::call<QtPrivate::List<>,void>(<lambda_2> &,void *,void **) qobjectdefs_impl.h:241
QtPrivate::QFunctorSlotObject<``OCC::Wizard::Jobs::ResolveUrlJobFactory::startJob'::`2'::<lambda_2>::operator()'::`2'::<lambda_2>,0,QtPrivate::List<>,void>::impl(int,QtPrivate::QSlotObjectBase *,QObject *,void **,bool *) qobjectdefs_impl.h:408
<unknown> 0x00007ff95bf070c3

OCC::ownCloudGui::settingsDialog() owncloudgui.cpp:400
OCC::Wizard::SetupWizardWindow::reject() setupwizardwindow.cpp:157

[saw-jan]

@TheOneRing Any steps to test this?

[TheOneRing]

If the client is terminated while the wizard is open (tested with test\manual\windows close event) the client crashes as it ties to access the
ocApp()->gui()->settingsDialog() which is already destroyed.

Logout would also work but observing the crash during logout is difficult.

[Salipa-Gurung]

Tested in desktop client version: ownCloud 5.0.0.11852-daily20230822 65017f
windows-10.0.19045

Steps I performed:

• Synced an account
• Opened Add New Account dialog
• Logged out that account from tray icon and also did Quit ownCloud

Crash dialog is not encountered.

cc: @TheOneRing