Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When file size limit on web server is reached with client, it kills sync #150

Closed
MTRichards opened this issue Dec 7, 2012 · 4 comments
Closed
Labels

Comments

@MTRichards
Copy link

Right now, when you try to upload a file bigger than the limit in php.ini max upload, the entire sync process fails, and stops. Instead, the app should offer a warning that it could not sync that file, and it should move on.

@dragotin
Copy link
Contributor

dragotin commented Dec 8, 2012

Hmm. I kind of disagree here. That would result in a permanent warning as the client would try again and again to sync the file and the sync would not be complete. But the problem is a severe configuration problem that can and should be solved.

Having that said, the problem will go away anyway having the big file support which is on the way.

@MTRichards
Copy link
Author

Hi! The permanent warning that a single file can't be uploaded is fine, that is the intended behavior of the client, and why you (will) have status overlay icons on files. If a file doesn't comply with the rules for file upload on the server, it should be skipped and get an overlay warning on the desktop...in the future. So, for now, the sync process should throw a warning in the log and move on, not stop the entire sync because a single file is too big. We need to gracefully handle this situation.

@jochenwezel
Copy link

yes, sync process should always catch any errors with single files and continue
but for sure, problematic files should be reported in info log with details on the problem (upload limit reached, not allowed to write into Shared folder (unsufficient rights), transfer errors, missing network connection, server/service down, ...) AND also be visible as problematic files in windows explorer (see #102 file icons overlays like dropbox or Tortoise SVN clients)

@dragotin
Copy link
Contributor

The fail of a single transmit does not end the sync any more, thats fixed. The root problem of large files will also be solved soon with big file chunking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants