Use credentials manager for prox credentials

[danimo]

Keychain

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[guruz]

<dragotin> Either add proxyPassword() and proxyUser() and proxyState()
<dragotin> or even more generic
<dragotin> with password( const QString& whichOne ) ;-)

[guruz]

As requested at other places, this should be able to store credentials for multiple proxies as users might be in different environments and don't want to retype their credentials.
(The question is if it is easy to get a "key" for that as Qt might not disclose on proxyAuthenticationRequired what is the proxy?)

[ckamm]

As of 2124098 we now store proxy passwords using "hostname:port" as key. But only for credentials that are entered in a special dialog when using the system proxy. The explicitly configured proxy still stores the credentials the same way as before.

I think we could either remove the proxy auth config from the network options altogether, or change how storage is done.

[TheOneRing]

We can discuss removal of credentials for manual specified proxies.

[TheOneRing]

It appears we already use qtkeychain https://github.com/owncloud/client/blob/master/src/gui/proxyauthhandler.cpp

[saw-jan]

Is there any way to confirm this? Or move it to Done?
CC @TheOneRing

[TheOneRing]

• Start 4.x
• Enter a proxy password
• Check that its saved to the settings.ini
• Start 5
• Check that the password is still restored (ther is something in the password field) and that it was removed from the settings.ini

Ideally we would have a proxy that requires credentials around.

[saw-jan]

Tested with ownCloud ownCloud 5.0.0.11369-daily20230703 511b96

1. Setting proxy password on 4.2	2. Started 5.0 client

3. Started 5.0 client	4. on keyring