Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X: Fix RTL languages in sync dialog #4336

Open
danimo opened this issue Jan 6, 2016 · 14 comments
Open

OS X: Fix RTL languages in sync dialog #4336

danimo opened this issue Jan 6, 2016 · 14 comments

Comments

@danimo
Copy link
Contributor

danimo commented Jan 6, 2016

Our custom painting code is not RTL aware (this is with incomplete farsi translations enabled):

image


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@danimo danimo added this to the 5.1.1 milestone Jan 6, 2016
@danimo
Copy link
Contributor Author

danimo commented Jan 6, 2016

Also, I am not sure where the opening braces come from and why the closing brace is missing, but this may be a bug in the Farsi translations.

@danimo danimo added the bug label Jan 6, 2016
ogoffart added a commit that referenced this issue Jan 7, 2016
@ogoffart ogoffart modified the milestones: 2.1.1-current, 5.1.1 Jan 7, 2016
@ogoffart ogoffart added the ReadyToTest QA, please validate the fix/enhancement label Jan 7, 2016
@Dianafg76
Copy link

@danimo, @ogoffart What are the steps to reproduce the issue?

@ogoffart
Copy link
Contributor

ogoffart commented Jan 8, 2016

change the language to arabic or farsi and observe that everything is fine and reverted.

One can also simulate RTL language using the -reverse command line option

@Dianafg76
Copy link

@ogoffart What are all the commands to simulate RTL language?

@Dianafg76 Dianafg76 added Needs info and removed ReadyToTest QA, please validate the fix/enhancement labels Jan 11, 2016
@Dianafg76
Copy link

@ogoffart If i open the terminal and writing ./owncloud -reverse I see is as before (all the elements and all the text is left aligned)
Desktop v ownCloud-2.1.1.3022-nightly20160111.pkg

@guruz guruz added the ReadyToTest QA, please validate the fix/enhancement label Jan 13, 2016
@guruz
Copy link
Contributor

guruz commented Jan 13, 2016

OS X: The progressbar is underlapping the [...] button and also going too far left even outside the window.
Let's try to fix this together.

@guruz guruz modified the milestones: 2.1.2-next, 2.1.1-current Jan 13, 2016
@guruz guruz removed the ReadyToTest QA, please validate the fix/enhancement label Jan 13, 2016
@ogoffart
Copy link
Contributor

So on windows it should now work. But on mac there is a problem in how the QMacStyle draw the progressbar in right to left. So it's now a platform specific issue

@guruz
Copy link
Contributor

guruz commented Jan 13, 2016

We concluded that on OS X this must be a problem with the QStyleOptionProgressBarV2 Qt OS X style (since it works when specifying -style fusion on OS X) when activating RTL.

@guruz guruz modified the milestones: backlog, 2.1.2-next Jan 13, 2016
@guruz guruz changed the title Fix RTL languages in sync dialog OS X: Fix RTL languages in sync dialog Jan 13, 2016
@danimo danimo removed this from the backlog milestone Feb 22, 2016
@TheOneRing
Copy link
Member

image

@TheOneRing
Copy link
Member

I'd say progress bar is ok but the arrows are broken

@TheOneRing
Copy link
Member

activity view is does not apply rtl
image

@TheOneRing
Copy link
Member

TheOneRing commented Oct 14, 2020

image

The indicator pointing right is a Qt mac upstream bug, windows and fusion display it correctly

TheOneRing added a commit that referenced this issue Oct 14, 2020
@Akidxx
Copy link

Akidxx commented Oct 14, 2020

I think it would be better like this

96014533-c9bc6a00-0e46-11eb-98d0-a9b172086cd7

Icons are being reversed and also the braces are from the other side (For Arabic or Persian language)

@TheOneRing
Copy link
Member

I think it would be better like this

96014533-c9bc6a00-0e46-11eb-98d0-a9b172086cd7

Icons are being reversed and also the braces are from the other side (For Arabic or Persian language)

Thx for your feedback. The arrows are a mac bug in the framework we use. And the strings are probably better when using Arabic. But I can imagine our Arabic /Persian translations are pretty incomplete...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants