Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAuth 2] Extend the "reopen browser to proceed" and error handling logic to accounts already created #5893

Closed
SamuAlfageme opened this issue Jul 12, 2017 · 3 comments
Assignees
Labels
bug p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement
Milestone

Comments

@SamuAlfageme
Copy link
Contributor

SamuAlfageme commented Jul 12, 2017

When the access to an account has been revoked (access/refresh token combination deleted/invalidated) there's no recovery option if the browser was closed but to restart the client.

Expected behavior

The account tab should implement the same behavior the wizard does when waiting for the redirect URL (i.e. the chance to relaunch the browser tab in case it was lost and timeout/error handling)

wizard

Actual behavior

The client does launch a new browser tab/window to authenticate with the application. If this window is closed, the account is left in a "configuration error" state with no chance to relaunch it again until the client itself is restarted (and the browser respawned). Transitions to "logged in" should not be possible.

blank diagram - page 1 2

Steps to reproduce

  1. Add an account via OAuth authentication
  2. Remove the access & refresh token from the server tables (= revoke)
  3. Relaunch the client / force sync.
  4. Close the browser.
@SamuAlfageme SamuAlfageme added bug p2-high Escalation, on top of current planning, release blocker labels Jul 12, 2017
@SamuAlfageme SamuAlfageme added this to the 2.4.0 milestone Jul 12, 2017
ogoffart added a commit that referenced this issue Jul 13, 2017
When the browser is open, ad a link in the ui to re-open
the browser.

Issue #5893
@ogoffart
Copy link
Contributor

Pull request: #5898

ogoffart added a commit that referenced this issue Jul 13, 2017
When the browser is open, ad a link in the ui to re-open
the browser.

Issue #5893
@ogoffart ogoffart added the ReadyToTest QA, please validate the fix/enhancement label Jul 13, 2017
@SamuAlfageme
Copy link
Contributor Author

SamuAlfageme commented Jul 21, 2017

@ogoffart can we disable the "log out" option from the "Account" dropdown & tray menu while "Obtaining authorization from the browser"? It's causing the AccountState to go into the "Disconnected" <-> "Signed out" loop:

no_connection_hiden

Either that, or trigger the "Obtaining authorization from the browser" on "Log in" selection.

ogoffart added a commit that referenced this issue Jul 21, 2017
Just to force the logic to re-ask the credenticals, in case we were
already asking them when singin off.

Issue: #5893 (comment)
ogoffart added a commit that referenced this issue Jul 26, 2017
Just to force the logic to re-ask the credenticals, in case we were
already asking them when singin off.

Issue: #5893 (comment)
@SamuAlfageme
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Development

No branches or pull requests

2 participants