Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting client while already running sometimes doesn't show settings window #7018

Closed
lazawan opened this issue Feb 6, 2019 · 11 comments
Closed

Comments

@lazawan
Copy link

lazawan commented Feb 6, 2019

steps to reproduce :
after client-configuration and client runs properly :

  • go to tray-icon in taskbar and quit owncloud
  • doppel-click on owncloud-icon on Desktop >> nothing opens just owncloud-client is started in background and tray-icon in taskbar appears again
  • again doppel-click >> nothing happens
  • again doppel-click >> now owncloud-window opens

regards

windows 10 client 2.5.3rc1

@guruz guruz added this to the 2.6.0 milestone Feb 6, 2019
@ckamm
Copy link
Contributor

ckamm commented Mar 7, 2019

It's intentional that starting the client usually doesn't lead to a window popping up. We don't want the settings window to be shown every windows startup.

What's odd is that the second time you start the client nothing happens. The intended behavior is that starting the client while it's already running will lead to the settings window popping up.

@ckamm ckamm added the sev4-low label Mar 7, 2019
@ckamm ckamm changed the title client 2.5.3rc1 doesn't start properly by doppel-clicking on windows 10 Starting client while already running sometimes doesn't show settings window Mar 7, 2019
@guruz
Copy link
Contributor

guruz commented Jun 4, 2019

Maybe some windows popup protection?
Moving to 2.6.1 though

@guruz guruz modified the milestones: 2.6.0, 2.6.1 Jun 4, 2019
@guruz guruz added sev3-medium and removed sev4-low labels Jun 4, 2019
@ogoffart
Copy link
Contributor

ogoffart commented Jun 4, 2019

There is a 10 second delay from startup for which we won't show the settings:

qCInfo(lcApplication) << "Running for" << _startedAt.elapsed() / 1000.0 << "sec";
if (_startedAt.elapsed() < 10 * 1000) {
// This call is mirrored with the one in int main()
qCWarning(lcApplication) << "Ignoring MSG_SHOWSETTINGS, possibly double-invocation of client via session restore and auto start";
return;
}
showSettingsDialog();

The reason is that some auto-start script tends to start the application twice :-/

@guruz
Copy link
Contributor

guruz commented Jun 4, 2019

session restore and auto start

That's a linux thing though?
Or I heard that Windows might do this too?

In general, our auto start setting could in theory launch the client with something like --from-autostart and then adjust behaviour somehow?
But maybe this is all not worth the trouble.

@HanaGemela
Copy link
Contributor

@TheOneRing is this issue fixed? There isn't ReadyToTest label
If it is fixed, could you specify the expected result here? When should settings dialog open?

@TheOneRing
Copy link
Member

I don't think so it would probably require changes to the installer to invoke the client with a -s

@TheOneRing
Copy link
Member

Adopt desktop files and windows shortcuts to pass -s to the client.

@TheOneRing
Copy link
Member

@ogoffart @guruz 641dece so the code was introduced to fix the issue on linux.
Do you know whether this was also an issue on mac?
I'd like to make the elapsed code linux only, as passing a -s if a user invoked it is easy.
As far as I can tell it is not possible to pass an argument on mac.

@jnweiger
Copy link
Contributor

jnweiger commented Mar 3, 2020

PR #7784 fixes this issue for me.
It nicely implements the general UX-rule that every user interaction should have an immediate reaction.
Regarding Windows and Mac: do we do the same there?

@HanaGemela
Copy link
Contributor

HanaGemela commented May 4, 2020

What is the expected results for macOS?

Current behaviour:
Windows - setting window opens on every double click
macOS - setting window never opens on double click
Linux - setting window opens on every double click

@michaelstingl
Copy link
Contributor

macOS - setting window never opens on double click

Okay for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants