[macOS] Several glitches when switching dark/light mode

[islamadel]

I use the latest version of ownCloud Client (2.5.3) on MacOS Mojave (10.14.3) Dark Mode activated
Under Settings Folder Names are blank

Expected behaviour

Folder Names should be displayed

Actual behaviour

Folder Names blank, can't choose what to sync

Steps to reproduce

1. Just Install and enable dark mode

Server configuration

Operating system:

Web server:

Database:

PHP version:

ownCloud version:

Storage backend (external storage):

Client configuration

Client version:

Operating system:

OS language:

Qt version used by client package (Linux only, see also Settings dialog):

Client package (From ownCloud or distro) (Linux only):

Installation path of client:

Logs

Please use Gist (https://gist.github.com/) or a similar code paster for longer
logs.

Template for output < 10 lines

1. Client logfile: Output of owncloud --logwindow or owncloud --logfile log.txt
   (On Windows using cmd.exe, you might need to first cd into the ownCloud directory)
   (See also http://doc.owncloud.org/desktop/2.2/troubleshooting.html#client-logfile )

2. Web server error log:

3. Server logfile: ownCloud log (data/owncloud.log):

See Screenshot:

[michaelstingl]

The team is working on a 2.5.4 release with Qt 5.12.x. You can already download a pre-release build here:
https://download.owncloud.com/desktop/daily/?C=M;O=D

Could you test and provide feedback?

[guruz]

@islamadel to be exact please try https://download.owncloud.com/desktop/daily/ownCloud-2.5.4.11337-daily20190219.pkg

[lazawan]

@guruz @michaelstingl
I used the build from guruz
https://download.owncloud.com/desktop/daily/ownCloud-2.5.4.11337-daily20190219.pkg

it looks so right now :

I think font for Account, Activity , General and Network is too dark :'(

[guruz]

QToolbar via https://github.com/guruz/qtmacgoodies/blob/master/src/macpreferenceswindow.mm#L85

Qt bug https://bugreports.qt.io/browse/QTBUG-71020

[guruz]

@lazawan thank you for the screenshots.

@michaelstingl We could just opt out of dark mode for now until we ourselves fixed all issues and Qt upstream has fixed theirs (maybe with our help)

https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_app?language=objc

If you need extra time to work on your app's Dark Mode support, you can temporarily opt out by including the NSRequiresAquaSystemAppearance key (with a value of YES) in your app’s Info.plist file. Setting this key to YES causes the system to ignore the user's preference and always apply a light appearance to your app.

Basically, try a 2.5.4 with this.

[michaelstingl]

@michaelstingl We could just opt out of dark mode for now until we ourselves fixed all issues and Qt upstream has fixed theirs (maybe with our help)

@guruz Yeah, let's do this in the 2.5.4.

We can keep it enabled in the daily builds, then we can check the progress…

[guruz]

Pushed this into 2.5 branch for now ^^.. maybe someone wants to try this with TOMORROWS daily build.

CC @ChrisEdS

[ChrisEdS]

Will do.

[ghost]

I also have Guruz's version running in my laptop. If it's needed to test a new release I don't mind do the job.

[guruz]

@ChrisEdS @ea1het https://download.owncloud.com/desktop/daily/ownCloud-2.5.4.11390-daily20190304.pkg :-)

[ChrisEdS]

It's getting better. What is still noticeable to me you find in the graphics.

[ChrisEdS]

I had to reinstall the old client first to see your "back to normal mode" fix.

[guruz]

Disabling dark mode in latest 2.5.4 daily builds works as per 710a2af#commitcomment-32655811
I'm moving this issue then and we fix it in a later release.

[michaelstingl]

According to https://bugreports.qt.io/browse/QTBUG-71020 , it got fixed with 5.12.3. We should try again with 710a2af reverted and latest Qt.

[ChrisEdS]

From my point of view, it looks good. @TheOneRing Do you agree?
I can do another test with the latest daily build if needed.

[HanaGemela]

Remaining issues:

1. 'Add folder Sync Connection' button moves slower then its title - this is more noticeable with dark mode

2. Too low contrast

[ChrisEdS]

Another thing are the icons for user and notifications. For my flavor, they are both too dark.

We should use a light grey instead?

[TheOneRing]

Fixed with Qt 5.14 so probably with 2.8.

[HanaGemela]

@TheOneRing please provide build with Qt 5.14 for testing

[TheOneRing]

It looked to me that the issues are already fixed in the latest builds with Qt 5.12.7 so current 2.6.3 builds should be ok

[HanaGemela]

Chris posted a screenshot with dark notifications (#7043 (comment)) so it used to be working. But now the server notifications do not have a dark mode in 2.6.3 (build 13252)

[davitol]

Seen in Version 2.7.0 (build 2098)

[michaelstingl]

Seen in Version 2.7.0 (build 2098)

Does a reboot fix it?

[davitol]

Does a reboot fix it?

Yes, it did. So ignore my previous comment 😄

[TheOneRing]

Yes there seem to be issue with scroll areas, same as #7043 (comment) ...
I tried to work around it and only made things worse.... I assume it is a Qt bug...

[voroyam]

I have the same on Big Sur

[ChrisEdS]

Which version do you use?

[ChrisEdS]

[voroyam]

2.7.4

[ChrisEdS]

I'm also on 2.7.4. - that's weird.

[TheOneRing]

It only happens when you switch themes.... I'll update the title