Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New "password required" capabilities lead to incorrect behavior #7247

Closed
ckamm opened this issue Jun 16, 2019 · 5 comments
Closed

New "password required" capabilities lead to incorrect behavior #7247

ckamm opened this issue Jun 16, 2019 · 5 comments
Assignees
@ckamm
Labels
Enhancement feature:sharing p2-high Escalation, on top of current planning, release blocker
Milestone
2.6.1

Comments

@ckamm
Copy link
Contributor

ckamm commented Jun 16, 2019 •
edited
Loading

The server 10.2.0 (edit: actually since 10.0.8, see below) has new fine-grained capabilities for requiring passwords for link shares. This setting can now be controlled independently for "read-only", "read/write" and "upload only" link shares.

The client should support these new capabilities.

However, there's an additional complication: it seems that if any one of these settings is enabled, the server will set the previous files_sharing/public/password/enforced capability to 1. This is unfortunate because it'll make the client require passwords for all public link shares when the server may only require it for one of the three types.

Found while testing with 10.2.0 for #7245.
@ckamm ckamm added this to the 2.6.0 milestone Jun 16, 2019
@ckamm ckamm self-assigned this Jun 16, 2019
@ckamm ckamm added the p2-high Escalation, on top of current planning, release blocker label Jun 16, 2019
@ckamm ckamm mentioned this issue Jun 17, 2019
Closed
@ckamm ckamm modified the milestones: 2.6.0, 2.6.1 Jun 17, 2019
@ckamm
Copy link
Contributor Author

ckamm commented Jun 17, 2019

Moving to 2.6.1 since it doesn't need to block 2.6.0 release. Users can still create shares, they just may be required to set passwords when that's not actually required for the particular link share type.

@pmaier1
Copy link

pmaier1 commented Jun 17, 2019

This has been added with 10.0.8 more than one year ago. https://doc.owncloud.com/server/10.2/admin_manual/release_notes.html#new-option-to-granularly-configure-public-link-password-enforcement

@ckamm
Copy link
Contributor Author

ckamm commented Jun 17, 2019

@pmaier1 Thanks, I hadn't looked it up yet. Unfortunate we didn't see it earlier, but at least not urgent then.

ckamm added a commit that referenced this issue Jul 17, 2019
@ckamm
Link sharing ui improvements
6140797 
- Respect fine-grained "password required" capability #7247
- Allow password/expiration to be added to shares that were created
  without these at a time when the server allowed that #7313
@ckamm ckamm mentioned this issue Jul 17, 2019
Merged
ckamm added a commit that referenced this issue Jul 17, 2019
@ckamm
Link sharing ui improvements
b887cd6 
- Respect fine-grained "password required" capability #7247
- Allow password/expiration to be added to shares that were created
  without these at a time when the server allowed that #7313
@michaelstingl
Copy link
Contributor

michaelstingl commented Sep 24, 2019 •
edited
Loading

Will this be in the future also solved with #7487 ?

@michaelstingl
Copy link
Contributor

fixed

@TheOneRing TheOneRing mentioned this issue Apr 7, 2020
Closed
47 tasks
@HanaGemela HanaGemela mentioned this issue Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckamm ckamm

Labels
Enhancement feature:sharing p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
2.6.1
Development

No branches or pull requests
4 participants
@michaelstingl @ckamm @pmaier1 @HanaGemela