-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tray icon still white with Windows light theme #7356
Comments
Please check with latest stable 2.5.4: |
Reproduced with 2.5.4 (build 11415) (understandably, see theme.cpp and utility_win.cpp). |
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Aug 16, 2019
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Aug 16, 2019
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Aug 19, 2019
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Aug 22, 2019
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Nov 5, 2019
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Oct 29, 2020
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Oct 29, 2020
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Nov 2, 2020
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Client version: Version 2.4.3 (build 10188) on Windows 10 1903
With the Windows 10 1903 update, a new light theme is available. When using monochrome icons with the light theme on, the dark systray icons should be used. Instead, the systray icon remains white on a light background and is unreadable.
If my understanding of the code is correct, implementing hasDarkSystray_private to detect the theme should solve the issue.
To reproduce:
Under Owncloud > General, set "Use Monochrome Icons".
Under Windows 10 Settings > Personalization > Colors, set "Choose your color" to "Light".
The text was updated successfully, but these errors were encountered: