Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray icon still white with Windows light theme #7356

Closed
krnkktz opened this issue Jul 30, 2019 · 2 comments
Closed

Tray icon still white with Windows light theme #7356

krnkktz opened this issue Jul 30, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@krnkktz
Copy link

krnkktz commented Jul 30, 2019

Client version: Version 2.4.3 (build 10188) on Windows 10 1903

With the Windows 10 1903 update, a new light theme is available. When using monochrome icons with the light theme on, the dark systray icons should be used. Instead, the systray icon remains white on a light background and is unreadable.

image

If my understanding of the code is correct, implementing hasDarkSystray_private to detect the theme should solve the issue.

To reproduce:
Under Owncloud > General, set "Use Monochrome Icons".
Under Windows 10 Settings > Personalization > Colors, set "Choose your color" to "Light".

@michaelstingl
Copy link
Contributor

Client version: Version 2.4.3 (build 10188) on Windows 10 1903

Please check with latest stable 2.5.4:
https://owncloud.org/download/#owncloud-desktop-client-windows

@krnkktz
Copy link
Author

krnkktz commented Jul 31, 2019

Reproduced with 2.5.4 (build 11415) (understandably, see theme.cpp and utility_win.cpp).

@ckamm ckamm added this to the 2.6.1 milestone Aug 1, 2019
@TheOneRing TheOneRing self-assigned this Aug 9, 2019
TheOneRing added a commit to TheOneRing/client that referenced this issue Aug 16, 2019
TheOneRing added a commit to TheOneRing/client that referenced this issue Aug 16, 2019
TheOneRing added a commit to TheOneRing/client that referenced this issue Aug 19, 2019
TheOneRing added a commit to TheOneRing/client that referenced this issue Aug 22, 2019
TheOneRing added a commit to TheOneRing/client that referenced this issue Nov 5, 2019
@michaelstingl michaelstingl modified the milestones: 2.6.1, 2.6.2 Nov 26, 2019
TheOneRing added a commit to TheOneRing/client that referenced this issue Oct 29, 2020
TheOneRing added a commit to TheOneRing/client that referenced this issue Oct 29, 2020
TheOneRing added a commit to TheOneRing/client that referenced this issue Nov 2, 2020
TheOneRing added a commit to TheOneRing/client that referenced this issue Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants