Sync should continue when a singe failure occurs

[mmattel]

Expected behaviour

Sync should continue

Actual behaviour

When you have a (very) slow backend like a FTP mount with a thin line, syncing stops because of eg. timeouts or the server replied with a error but an empty reply message (red line in sync screen) even there are much more items/mounts to be synced.

Server configuration

Operating system: Ubuntu 18.04

Web server: nginx

Database: mariadb

PHP version: 7.2

ownCloud version: 10.3

Storage backend (external storage): SMB, FTP

Client configuration

Client version: 2.6

Operating system: macOS

OS language: DE

[michaelstingl]

@mmattel Thanks for reporting! Could you post the relevant lines from the client debug log?
https://doc.owncloud.org/desktop/troubleshooting.html#log-files

[mmattel]

Here we go. I neutralized the content regarding sensitive information.
You can have the full .gz log if you provide me a secure upload location.

11-12 19:01:45:385 [ warning sync.networkjob ]:	QNetworkReply::UnknownServerError "Error transferring https://myserver.xyz/remote.php/dav/files/myuser.lastname/myuser@mountname/folder - server replied: " QVariant(int, 504)
11-12 19:01:45:385 [ info sync.networkjob.lscol ]:	LSCOL of QUrl("https://myserver.xyz/remote.php/dav/files/myuser.lastname/myuser@mountname/folder") FINISHED WITH STATUS "UnknownServerError Error transferring https://myserver.xyz/remote.php/dav/files/myuser.lastname/myuser@mountname/folder - server replied: "
11-12 19:01:45:385 [ warning sync.discovery ]:	LSCOL job error "Error transferring https://myserver.xyz/remote.php/dav/files/myuser.lastname/myuser@mountname/folder - server replied: " 504 QNetworkReply::UnknownServerError
11-12 19:01:45:385 [ warning sync.discovery ]:	Server error in directory "myuser@mountname/folder" 504
11-12 19:01:45:388 [ info sync.engine ]:	Sync run took  202947 ms
11-12 19:01:45:388 [ debug sync.localdiscoverytracker ]	[ OCC::LocalDiscoveryTracker::slotSyncFinished ]:	sync failed, keeping last sync's local discovery path list
11-12 19:01:45:388 [ debug sync.networkjob ]	[ OCC::AbstractNetworkJob::slotFinished ]:	Network job OCC::LsColJob finished for "/myuser@mountname/folder"
11-12 19:01:45:388 [ info gui.folder ]:	Client version 2.6.0 (build 12703)  Qt 5.12.5  SSL  OpenSSL 1.1.1d  10 Sep 2019
11-12 19:01:45:388 [ warning gui.folder ]:	SyncEngine finished with ERROR
11-12 19:01:45:388 [ info gui.folder ]:	Folder sync result:  2
11-12 19:01:45:388 [ info gui.folder ]:	the last 1 syncs failed
11-12 19:01:45:390 [ info gui.application ]:	Sync state changed for folder  "https://myserver.xyz/remote.php/dav/files/myuser.lastname/" :  "Error"

If I renove the particular folder /folder from the sync list, sync continues flawless.
Else all other open sync items do not get synced.

[michaelstingl]

@ogoffart Why not continue after a 504? (especially if it's a mounted folder?)

[ogoffart]

Why not continue after a 504? (especially if it's a mounted folder?)

The original code from csync was stopping at any error.
Then we changed the code to ignore the folder in for some error code, one by one, as deemed necessary.
But the code 504 was not seen before and is therefore not ignored.

[ogoffart]

In PR #7588 , i ignore the directory and continue the sync in case of any HTTP error >= 403

[HanaGemela]

@mmattel could you install testpilot https://software.opensuse.org//download.html?project=isv:ownCloud:testpilot:testing&package=testpilotcloud-client
and see if it fixes your issue?