Crash with vfs_suffix

[TheOneRing]

When moving files around it is possible that a virtual file is recreated after it was moved.
When that now non existing virtual file is moved the client crashes with an assertion.

This crash was produced using an external dropbox share.
In order to reproduce it the same file needs to be moved until we get a duplicate, then the duplicate needs to be moved.

https://github.com/owncloud/client/blob/master/src/libsync/discoveryphase.cpp#L162

log.txt

2   pthread_kill                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               (x86_64) /usr/lib/system/libsystem_pthread.dylib      0x7fff72bfdbc1 
3   abort                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      (x86_64) /usr/lib/system/libsystem_c.dylib            0x7fff72ac7a1c 
4   qt_message_fatal(QtMsgType, QMessageLogContext const&, QString const&)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     qlogging.cpp                                     1907 0x10207e7a8    
5   QMessageLogger::fatal(const char *, ...) const                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             qlogging.cpp                                     888  0x102583a2b    
6   OCC::DiscoveryPhase::findAndCancelDeletedJob(QString const&)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               discoveryphase.cpp                               162  0x100ff0a5a    
7   OCC::ProcessDirectoryJob::processFileAnalyzeLocalInfo(QSharedPointer<OCC::SyncFileItem> const&, OCC::ProcessDirectoryJob::PathTuple, OCC::LocalInfo const&, OCC::RemoteInfo const&, OCC::SyncJournalFileRecord const&, OCC::ProcessDirectoryJob::QueryMode)::$_7::operator()(OCC::Result<QString, OCC::HttpError> const&)                                                                                                                                                                                                                                                                                                                                                  discovery.cpp                                    1003 0x100fe7441    
8   QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<OCC::Result<QString, OCC::HttpError> const&>, void, OCC::ProcessDirectoryJob::processFileAnalyzeLocalInfo(QSharedPointer<OCC::SyncFileItem> const&, OCC::ProcessDirectoryJob::PathTuple, OCC::LocalInfo const&, OCC::RemoteInfo const&, OCC::SyncJournalFileRecord const&, OCC::ProcessDirectoryJob::QueryMode)::$_7>::call(OCC::ProcessDirectoryJob::processFileAnalyzeLocalInfo(QSharedPointer<OCC::SyncFileItem> const&, OCC::ProcessDirectoryJob::PathTuple, OCC::LocalInfo const&, OCC::RemoteInfo const&, OCC::SyncJournalFileRecord const&, OCC::ProcessDirectoryJob::QueryMode)::$_7&, void * *) qobjectdefs_impl.h                               146  0x100fe7212    
9   void QtPrivate::Functor<OCC::ProcessDirectoryJob::processFileAnalyzeLocalInfo(QSharedPointer<OCC::SyncFileItem> const&, OCC::ProcessDirectoryJob::PathTuple, OCC::LocalInfo const&, OCC::RemoteInfo const&, OCC::SyncJournalFileRecord const&, OCC::ProcessDirectoryJob::QueryMode)::$_7, 1>::call<QtPrivate::List<OCC::Result<QString, OCC::HttpError> const&>, void>(OCC::ProcessDirectoryJob::processFileAnalyzeLocalInfo(QSharedPointer<OCC::SyncFileItem> const&, OCC::ProcessDirectoryJob::PathTuple, OCC::LocalInfo const&, OCC::RemoteInfo const&, OCC::SyncJournalFileRecord const&, OCC::ProcessDirectoryJob::QueryMode)::$_7&, void *, void * *)                qobjectdefs_impl.h                               256  0x100fe7191    
10  QtPrivate::QFunctorSlotObject<OCC::ProcessDirectoryJob::processFileAnalyzeLocalInfo(QSharedPointer<OCC::SyncFileItem> const&, OCC::ProcessDirectoryJob::PathTuple, OCC::LocalInfo const&, OCC::RemoteInfo const&, OCC::SyncJournalFileRecord const&, OCC::ProcessDirectoryJob::QueryMode)::$_7, 1, QtPrivate::List<OCC::Result<QString, OCC::HttpError> const&>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *)                                                                                                                                                                                                                               qobjectdefs_impl.h                               439  0x100fe713d    
11  QtPrivate::QSlotObjectBase::call(QObject *, void * *)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      qobjectdefs_impl.h                               394  0x10238e7e6    
12  QMetaObject::activate(QObject *, int, int, void * *)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       qobject.cpp                                      3784 0x1023d5282    
13  QMetaObject::activate(QObject *, QMetaObject const *, int, void * *)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       qobject.cpp                                      3657 0x1023d490d    
14  OCC::RequestEtagJob::finishedWithResult(OCC::Result<QString, OCC::HttpError> const&)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       moc_networkjobs.cpp                              1394 0x100f9800a    
15  OCC::RequestEtagJob::finished()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            networkjobs.cpp                                  129  0x10101bce8    
16  OCC::AbstractNetworkJob::slotFinished()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    abstractnetworkjob.cpp                           275  0x101015d5c    
17  QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (OCC::AbstractNetworkJob:: *)()>::call(void (OCC::AbstractNetworkJob:: *)(), OCC::AbstractNetworkJob *, void * *)                                                                                                                                                                                                                                                                                                                                                                                                                                                                           qobjectdefs_impl.h                               152  0x101019b0c    
18  void QtPrivate::FunctionPointer<void (OCC::AbstractNetworkJob:: *)()>::call<QtPrivate::List<>, void>(void (OCC::AbstractNetworkJob:: *)(), OCC::AbstractNetworkJob *, void * *)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            qobjectdefs_impl.h                               185  0x101019a73    
19  QtPrivate::QSlotObject<void (OCC::AbstractNetworkJob:: *)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                qobjectdefs_impl.h                               414  0x1010199a6    
20  QtPrivate::QSlotObjectBase::call(QObject *, void * *)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      qobjectdefs_impl.h                               394  0x10238e7e6    
... <More>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          

[TheOneRing]

Related:
https://sentry.io/organizations/owncloud/issues/1486987547/?project=79001&query=is%3Aunresolved

#7714