Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HttpCredentialsGui::showDialog() modal #7833

Closed
TheOneRing opened this issue Mar 31, 2020 · 2 comments
Closed

Make HttpCredentialsGui::showDialog() modal #7833

TheOneRing opened this issue Mar 31, 2020 · 2 comments

Comments

@TheOneRing
Copy link
Member

The password dialog is non modal and thus can be "lost" beneath other windows.

See:
https://github.com/owncloud/client/blob/master/src/gui/creds/httpcredentialsgui.cpp#L115

My suggestion would be to add a singleton to access the SettingSialog from everywhere and thus provide a parent for that dialog.

@TheOneRing
Copy link
Member Author

@ogoffart what do you think about that singleton?

@ogoffart
Copy link
Contributor

Yes, a singleton makes sense for this.
I believe there is already a ownCloudGui singleton that could be used to access the settings.
Note that the settings is not always visible.

TheOneRing added a commit to TheOneRing/client that referenced this issue Jun 29, 2020
TheOneRing added a commit to TheOneRing/client that referenced this issue Jun 29, 2020
@jnweiger jnweiger mentioned this issue Oct 13, 2020
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants