-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make HttpCredentialsGui::showDialog() modal #7833
Comments
@ogoffart what do you think about that singleton? |
Yes, a singleton makes sense for this. |
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Jun 29, 2020
TheOneRing
added a commit
to TheOneRing/client
that referenced
this issue
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The password dialog is non modal and thus can be "lost" beneath other windows.
See:
https://github.com/owncloud/client/blob/master/src/gui/creds/httpcredentialsgui.cpp#L115
My suggestion would be to add a singleton to access the SettingSialog from everywhere and thus provide a parent for that dialog.
The text was updated successfully, but these errors were encountered: