Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder watcher has a case sensitive startsWith #8732

Closed
TheOneRing opened this issue Jun 15, 2021 · 0 comments
Closed

Folder watcher has a case sensitive startsWith #8732

TheOneRing opened this issue Jun 15, 2021 · 0 comments
Milestone
2.9.0

Comments

@TheOneRing
Copy link
Member

In https://github.com/owncloud/client/blob/master/src/gui/folder.cpp#L532 the comparison is case sensitive while the file system might not be.

This only causes an issue if the sync folder does not match the casing on the file system.

I'd suggest we refactor comparisons like this ( we have multiple and multiple approaches to handle the casing) and move them to the Filesystem:: namespace.
Filesystem:: startsWith.
@TheOneRing TheOneRing modified the milestones: 2.10.0, 2.9.0 Jun 15, 2021
TheOneRing added a commit that referenced this issue Jun 25, 2021
@TheOneRing
Fix incorrect string comparison in check wheter we are responsible fo…
c63c0dc 
…r a file

Fixes: #8732
TheOneRing added a commit that referenced this issue Jun 25, 2021
@TheOneRing
Fix incorrect string comparison in check wheter we are responsible fo…
65b67a3 
…r a file

Fixes: #8732
(cherry picked from commit aa72b52)
@jnweiger jnweiger mentioned this issue Aug 23, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
1 participant
@TheOneRing