Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.9.0 build with libcloudproviders is broken #8996

Closed
antonio-rojas opened this issue Sep 9, 2021 · 3 comments
Closed

2.9.0 build with libcloudproviders is broken #8996

antonio-rojas opened this issue Sep 9, 2021 · 3 comments
Labels
Needs info
Milestone
2.9.1

Comments

@antonio-rojas
Copy link

Expected behaviour

It builds

Actual behaviour

/build/owncloud-client/src/client/src/gui/libcloudproviders/libcloudproviders.cpp:85:52: error: ‘class OCC::FolderMan’ has no member named ‘list’
   85 |     const auto newFolders = FolderMan::instance()->list();
      |                                                    ^~~~

FolderMan::list() was removed in commit 3f5163a
@TheOneRing
Copy link
Member

I'd recommend to disable the feature for now as it not really provides any benefits.
But we will fix it with 2.9.1

@TheOneRing TheOneRing added this to the 2.9.1 milestone Sep 9, 2021
@TheOneRing
Copy link
Member

TheOneRing commented Sep 15, 2021 •
edited
Loading

What is the current state of libcloudproviders, what does it provide.
The only available documentation is what its supposed to provide one day form 2015
https://csorianognome.wordpress.com/2015/07/07/cloud-providers/ .
https://gitlab.gnome.org/World/libcloudproviders

dragotin added a commit that referenced this issue Sep 15, 2021
@dragotin
Fix build with libcloudproviders, reported in #8996
608c143
@dragotin dragotin mentioned this issue Sep 15, 2021
Closed
TheOneRing pushed a commit that referenced this issue Sep 27, 2021
@dragotin @TheOneRing
Fix build with libcloudproviders, reported in #8996
8782aaf
TheOneRing pushed a commit that referenced this issue Sep 28, 2021
@dragotin @TheOneRing
Fix build with libcloudproviders, reported in #8996
befae3a
@TheOneRing
Copy link
Member

TheOneRing commented Sep 28, 2021 •
edited
Loading

Fixed in 2.9.1

@gabi18 gabi18 mentioned this issue Sep 29, 2021
Closed
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs info
Projects
None yet
Milestone
2.9.1
Development

Successfully merging a pull request may close this issue.

Fix build with libcloudproviders 2.9 owncloud/client
2 participants
@TheOneRing @antonio-rojas