Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to filter issue table by issue type #9000

Closed
TheOneRing opened this issue Sep 10, 2021 · 3 comments · Fixed by #9023
Closed

Allow to filter issue table by issue type #9000

TheOneRing opened this issue Sep 10, 2021 · 3 comments · Fixed by #9023
Assignees
Milestone

Comments

@TheOneRing
Copy link
Member

Add the ability to filter by issue type to the context menu of the issue type column header.

@TheOneRing
Copy link
Member Author

TheOneRing commented Sep 13, 2021

#9010 ads the status to the table.
Filtering is still missing.

I suppose we only need filtering in the issue widget not the protocol widget.

The filter should be added to the header context menu.
image

The Model: https://github.com/owncloud/client/blob/2.9/src/gui/models/protocolitemmodel.cpp
The context menu:

TheOneRing added a commit that referenced this issue Sep 13, 2021
@erikjv
Copy link
Collaborator

erikjv commented Sep 13, 2021

As far as I can see, OCC::Models::displayFilterDialog is used in two places. Do both need filtering by status?

The context menu is the same no matter which column you click, so I assume we need to show both the account filter, and the status filter. Also both filters should be usable independent of each other (e.g. "show all excluded for admin@")?

Or should there be only 1 active filter, depending on which column you click, that resets the filter for the other column?

The filtering can be done by a subclass of QSortFilterProxyModel, which asks for the UnderlyingDataRole of the item, and filters based on that.

@TheOneRing
Copy link
Member Author

I think the filter only makes sense on the issue widget, the column is hidden on the protocol view.
It might come handy to allow to filter by account and status?
Whether we want to allow multiple accounts/states as filter, depends on the complexity of the solution.

TheOneRing added a commit that referenced this issue Sep 14, 2021
@erikjv erikjv self-assigned this Sep 14, 2021
erikjv added a commit that referenced this issue Sep 14, 2021
@TheOneRing TheOneRing modified the milestones: 2.9.1, 2.9.2 Sep 15, 2021
erikjv added a commit that referenced this issue Sep 16, 2021
erikjv added a commit that referenced this issue Sep 16, 2021
erikjv added a commit that referenced this issue Sep 16, 2021
erikjv added a commit that referenced this issue Sep 17, 2021
erikjv added a commit that referenced this issue Sep 17, 2021
erikjv added a commit that referenced this issue Sep 17, 2021
erikjv added a commit that referenced this issue Sep 23, 2021
erikjv added a commit that referenced this issue Sep 24, 2021
erikjv added a commit that referenced this issue Sep 27, 2021
erikjv added a commit that referenced this issue Sep 27, 2021
erikjv added a commit that referenced this issue Sep 29, 2021
@gabi18 gabi18 mentioned this issue Sep 29, 2021
46 tasks
erikjv added a commit that referenced this issue Sep 29, 2021
erikjv added a commit that referenced this issue Sep 29, 2021
erikjv added a commit that referenced this issue Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants