OAuth2: Restart local socket after an error occured

[michaelstingl]

Expected behaviour

Login attempt after "Error returned from the server: code verifier invalid" should succeed.

Actual behaviour

Invalid redirect URI with localhost:0 is generated

Steps to reproduce

1. Login to demo.owncloud.com with user demo:demo in system browser
2. Add new server account with demo.owncloud.com to desktop client
3. "Switch User" in web UI (OAuth 2.0 app)
4. Login with user test:test in web UI
5. "Authorise" in web UI, to authorise desktop client
   ==> Login Error Error returned from the server: code verifier invalid
6. Go back to desktop client, click "Re-open Browser"
   ==> New URL contain invalid redirect URI with localhost:0

Server configuration

curl https://demo.owncloud.com/status.php
{"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"10.8.0.4","versionstring":"10.8.0","edition":"Enterprise","productname":"ownCloud"}

Client configuration

testpilotcloud 2.9.1 (build 5501) 42fb29 Oct 13 2021 10:57:21
Libraries Qt 5.12.11, OpenSSL 1.1.1k 25 Mar 2021
Using virtual files plugin: suffix
osx-21.1.0

Related: owncloud/oauth2#309

[github-actions]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

[TheOneRing]

Turned out to not be a client issue.

[saw-jan]

@michaelstingl, I have tested this behavior manually as of #9290 (comment)
My findings:

• ❗ step 5 has the same error message Login Error Error returned from the server: code verifier invalid redirected to localhost:
• ✔️ step 6 redirects to the correct server URL not to localhost