Possible endless loop when conflict file is locked

[TheOneRing]

If the client tries to rename a file to its conflict file name and that file is currently locked, the client fails, still creates an error message and immediately tries again.

The result is a flickering ui and a log full of hundreds of errors.

[dragotin]

Same if the a file is locked (ie. in Office) and the user clicks on "Dehydrate files" using Windows VFS. That results in endless loops trying to dehydrate the file which fails until it is unlocked.

[gabi18]

Tested ownCloud-2.10.0-daily20211214.6294.x64.msi on Windows10 20H2 (Build 19042.1348)

Steps done:

• open 'New text file.odt' in LibreOffice
• edit and save
  Result: Client shows 'i' and info that file is locked in 'Not synced' tab -> OK
• 'Free up space' on right click on file 'New text file.odt'
  Result: Client shows 'i' - no flickering, no endless loop of retry -> OK
• 'Free up space' on folder 'Neuer Ordner (2)'
  Result: nothing changed -> OK
• exit LibreOffice
  Result: 'New text file.odt' is synced to server, client shows green check mark -> OK
  cloud icon in Explorer for file 'New text file.odt' -> OK
  Spinning icon remains for folder 'Neuer Ordner (2)', also after 'Force sync' -> NOT ok

Logfile:
client-2-10.log.gz

I cannot find errors concerning the folder 'Neuer Ordner (2)' only.
Lines in the logfile for the file 'New text file.odt':

12-15 09:37:55:540 [ warning sync.vfs.win ]:	void __cdecl OCC::VfsWin::fileStatusChanged(const class QString &,class OCC::SyncFileStatus) : couldn't CfSetInSyncState for "C:/Users/gabi/ownCloud26/Neuer Ordner (2)/New text file.odt"  status  OCC::SyncFileStatus::StatusError : "WindowsError: ffffffff80070178: Die Datei ist keine Clouddatei."
...
12-15 09:37:55:554 [ info sync.database ]:	Setting blacklist entry for "Neuer Ordner (2)/New text file.odt" 4 "C:/Users/gabi/ownCloud26/Neuer Ordner (2)/New text file.odt the file is currently in use" 1639557475 3125 1639557005 "10d69394d7efbf1df7ac0eb7c4c20c83" "" OCC::SyncJournalErrorBlacklistRecord::Category::LocalSoftError
12-15 09:37:55:554 [ warning sync.propagator ]:	Could not complete propagation of "Neuer Ordner (2)/New text file.odt" by OCC::PropagateIgnoreJob(0x1cf032fc030) with status OCC::SyncFileItem::SoftError and error: "C:/Users/gabi/ownCloud26/Neuer Ordner (2)/New text file.odt the file is currently in use"
12-15 09:37:55:554 [ info sync.propagator ]:	blacklisting  "Neuer Ordner (2)/New text file.odt"  for  3125 , retry count  4
12-15 09:37:55:554 [ warning sync.vfs.win ]:	void __cdecl OCC::VfsWin::fileStatusChanged(const class QString &,class OCC::SyncFileStatus) : couldn't CfSetInSyncState for "C:/Users/gabi/ownCloud26/Neuer Ordner (2)/New text file.odt"  status  OCC::SyncFileStatus::StatusError : "WindowsError: ffffffff80070178: Die Datei ist keine Clouddatei."
...
12-15 09:38:03:631 [ warning sync.vfs.win ]:	void __cdecl OCC::VfsWin::fileStatusChanged(const class QString &,class OCC::SyncFileStatus) : couldn't CfSetInSyncState for "C:/Users/gabi/ownCloud26/Neuer Ordner (2)/New text file.odt"  status  OCC::SyncFileStatus::StatusSync : "WindowsError: ffffffff80070178: Die Datei ist keine Clouddatei."
...
12-15 09:38:06:049 [ debug sync.statustracker ]	[ OCC::SyncFileStatusTracker::slotItemCompleted ]:	Item completed "Neuer Ordner (2)/New text file.odt" OCC::SyncFileItem::Success SyncInstruction(CSYNC_INSTRUCTION_SYNC)

[gabi18]

Test ownCloud-2.10.0-daily20211216.6305.x64.msi on Windows10 20H2 (Build 19042.1348)

1. Test

• open existing file in LibreOffice
• free up space on file -> OK, no endless retry (spinning icon for file and folder), 'Not Synced' tab shows' "... file is currently in use"
• exit LibreOffice -> folder status: cloud icon, file status: full file (NOT reproducible)

20211216_1322_owncloud.log.3.gz
20211216_1323_owncloud.log.0.gz

2. Test

• open existing file in LibreOffice
• edit file and save -> 'Not synced' "... file is currently in use" -> OK
• free up space on file -> OK, no endless retry (spinning icon for file and folder)
• exit LibreOffice -> folder status: cloud icon, file status: cloud icon -> OK
  client-2-10-save-changes.log.gz

3. Test

• open existing file in LibreOffice
• free up space on file -> OK, 'Not Synced' tab shows' "... file is currently in use"
• exit LibreOffice without saving-> file status: cloud icon -> OK, folder status: spinning, no change on 'Force Sync', changes to cloud icon after Explorer restart
  client-2-10-exit-office.log.gz
  This scenario also runs successful, means cloud icon for file and folder - but it takes some seconds (the client shows the 'i' and after a while it changes to green check mark)
  client-2-10-exit-office-ok.log.gz