Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Watcher missing for deletes of Locked files #9293

Closed
dragotin opened this issue Dec 15, 2021 · 0 comments
Closed

Lock Watcher missing for deletes of Locked files #9293

dragotin opened this issue Dec 15, 2021 · 0 comments
Labels
Milestone

Comments

@dragotin
Copy link
Contributor

Testcase:

  • Create a directory and put a Libre Office (LO) file in. Let that sync to the server. Open the file in LO to lock it.
  • Remove the directory on the server side completely.

What is expected:

  1. For the case where the file was not modified locally, the client should remove the file and directory. That is happening (ok) but only on force-sync. That means that there is no lock watcher enabled in this case that checks the file regularly.
  2. For the case where the file was modified locally, the client should upload the changed file and not remove the dir. That is not the case. The client removes the file even when the file was modified.

That shows two bugs:

  1. There should be a log watcher for deletes that failed due to lock that automatically.
  2. Before propagating the remove from remote to local, it needs to be checked if the file was modified, and if, the file should be uploaded to not loose the changes. @hodyroff pls. acknowledge.
@dragotin dragotin added the bug label Dec 15, 2021
@dragotin dragotin added this to the 2.10.0 milestone Dec 15, 2021
TheOneRing added a commit that referenced this issue Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant