Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File modified during upload should not be handled by the local ignore list #9382

Closed
TheOneRing opened this issue Jan 24, 2022 · 2 comments
Closed
Milestone

Comments

@TheOneRing
Copy link
Member

If an upload of a file fails 3 times in a row because it was modified during sync, we add it to an ignore list.

This can easily happen for files managed by an IDE.

Issues         ,File                                                            ,Folder                        ,Size  ,Account             ,Time                ,Status              ,
Local file changed during sync.,untitled1/main.cpp                                              ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.848,Info                ,
Local file changed during sync.,build-untitled1-KDE-Debug/Testing/Temporary/LastTest.log        ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.837,Info                ,
File/Folder is ignored because it's hidden.,build-untitled1-KDE-Debug/.ninja_log                            ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.829,Excluded            ,
File/Folder is ignored because it's hidden.,build-untitled1-KDE-Debug/.ninja_deps                           ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.821,Excluded            ,
File/Folder is ignored because it's hidden.,build-untitled1-KDE-Debug/.cmake                                ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.814,Excluded            ,
Local file changed during sync.,build-untitled1-KDE-Debug/CMakeFiles/rules.ninja                ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.807,Info                ,
Local file changed during sync.,build-untitled1-KDE-Debug/CMakeFiles/cmake.check_cache          ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.800,Info                ,
Local file changed during sync.,build-untitled1-KDE-Debug/CMakeFiles/clean_additional.cmake     ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.794,Info                ,
Local file changed during sync.,build-untitled1-KDE-Debug/CMakeFiles/TargetDirectories.txt      ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.788,Info                ,
Local file changed during sync.,build-untitled1-KDE-Debug/CMakeFiles/CMakeOutput.log            ,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.778,Info                ,
Local file changed during sync.,build-untitled1-KDE-Debug/CMakeFiles/3.21.21080301-MSVC_2/CMakeRCCompiler.cmake,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.773,Info                ,
Local file changed during sync.,build-untitled1-KDE-Debug/CMakeFiles/3.21.21080301-MSVC_2/CMakeCXXCompiler.cmake,testpilotcloud2               ,      ,test@XXX,2022-01-24T09:13:09.767,Info                ,
@TheOneRing TheOneRing added this to the 2.10.1 milestone Jan 24, 2022
@TheOneRing TheOneRing changed the title File modigied during upload should not be handled by the local ignore list File modified during upload should not be handled by the local ignore list Jan 24, 2022
@TheOneRing
Copy link
Member Author

@Talank I think there was a related squish test?

@Talank
Copy link
Contributor

Talank commented Jan 24, 2022

We only had one test for blacklisted file, which is skipped currently

Scenario: Filenames that are rejected by the server are reported
I do not think there is a test for this like try to sync upto 3 time ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants