Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding option for folder sync wizard #9523

Closed
michaelstingl opened this issue Mar 17, 2022 · 6 comments
Closed

Branding option for folder sync wizard #9523

michaelstingl opened this issue Mar 17, 2022 · 6 comments
Milestone

Comments

@michaelstingl
Copy link
Contributor

tbd

@gabi18
Copy link
Contributor

gabi18 commented Apr 5, 2022

Tested with 2.10.1-rc2 testpilotcloud (compiled from git branch 2.10) on openSUSE 15.3:

  • confirmed that selecting the sync root as destination is prevented

testpilot-syncroot

  • but it's still possible to select an existing subfolder

testpilot-subfolder

Is this intended?

@gabi18
Copy link
Contributor

gabi18 commented Apr 5, 2022

Not sure if it's a problem of my self-compiled client:
I get a crash when I try to create a new folder ("Create Folder", enter name on 'Create Remote Folder' popup and click "OK")

04-05 10:54:21:594 [ fatal default ]:	ENSURE: "relativePath.startsWith(QLatin1Char('/'))" in file /home/gabriele/development/owncloud/client/src/libsync/abstractnetworkjob.cpp, line 201 QUrl OCC::AbstractNetworkJob::makeDavUrl(const QString&) const

20220405_1053_owncloud.log.2.gz

@TheOneRing
Copy link
Member

Not sure if it's a problem of my self-compiled client: I get a crash when I try to create a new folder ("Create Folder", enter name on 'Create Remote Folder' popup and click "OK")

04-05 10:54:21:594 [ fatal default ]:	ENSURE: "relativePath.startsWith(QLatin1Char('/'))" in file /home/gabriele/development/owncloud/client/src/libsync/abstractnetworkjob.cpp, line 201 QUrl OCC::AbstractNetworkJob::makeDavUrl(const QString&) const

Only a warning for devs

@TheOneRing
Copy link
Member

Not sure if it's a problem of my self-compiled client: I get a crash when I try to create a new folder ("Create Folder", enter name on 'Create Remote Folder' popup and click "OK")

04-05 10:54:21:594 [ fatal default ]:	ENSURE: "relativePath.startsWith(QLatin1Char('/'))" in file /home/gabriele/development/owncloud/client/src/libsync/abstractnetworkjob.cpp, line 201 QUrl OCC::AbstractNetworkJob::makeDavUrl(const QString&) const

Only a warning for devs

Crash only happens in debug builds.

@michaelstingl
Copy link
Contributor Author

  • but it's still possible to select an existing subfolder

testpilot-subfolder

Is this intended?

Yes, all subfolders allowed 👍

@gabi18
Copy link
Contributor

gabi18 commented Apr 7, 2022

Also confirmed with btr-client 2.10.1 (build 7211) built in ownbrander with unchecked option "Allow duplicated folder sync pair":

btr-noduplcated-syncroot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants