Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local file changed during sync can still trigger error timeouts #9924

Closed
TheOneRing opened this issue Jul 14, 2022 · 3 comments · Fixed by #9932
Closed

Local file changed during sync can still trigger error timeouts #9924

TheOneRing opened this issue Jul 14, 2022 · 3 comments · Fixed by #9932
Assignees
Labels
Milestone

Comments

@TheOneRing
Copy link
Member

git grep "Local file changed during sync" -- .\src\
src/libsync/propagateupload.cpp:        done(SyncFileItem::Message, tr("Local file changed during sync. It will be resumed."));
src/libsync/propagateuploadng.cpp:            abortWithError(SyncFileItem::SoftError, tr("Local file changed during sync."));
src/libsync/propagateuploadtus.cpp:            abortWithError(SyncFileItem::SoftError, tr("Local file changed during sync."));
src/libsync/propagateuploadv1.cpp:            abortWithError(SyncFileItem::SoftError, tr("Local file changed during sync."));
@TheOneRing TheOneRing added this to the 3.0 milestone Jul 14, 2022
@erikjv
Copy link
Collaborator

erikjv commented Jul 18, 2022

This happens in TestChunkingNG::testCreateConflictWhileSyncing

@TheOneRing TheOneRing added the bug label Jul 19, 2022
@TheOneRing TheOneRing self-assigned this Jul 20, 2022
TheOneRing added a commit that referenced this issue Jul 20, 2022
TheOneRing added a commit that referenced this issue Jul 21, 2022
TheOneRing added a commit that referenced this issue Jul 21, 2022
@HanaGemela
Copy link
Contributor

Steps to recreate:

  1. Lock a file by opening Word
  2. Modify the file and keep it open
  3. Save the file -> triggers sync

Actual result: Three attempts -> blacklisted file
Expected result: Locked and not uploaded, in the not sync tab, uploaded after closing the file

@bishwasojha
Copy link

  • when a file is open in Word/LibreOffice , file is Locked and not uploaded, file lies in the not sync tab
  • After a file is closed, file is uploaded to server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants