Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work/load translations early #11300

Merged
merged 3 commits into from Oct 27, 2023
Merged

Work/load translations early #11300

merged 3 commits into from Oct 27, 2023

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Oct 18, 2023 •
edited by fmoc

Remove the --confdir option and load translations before any messages are shown.

Fixes #11246. Fixes #11142.

Waits on #11316.

@erikjv erikjv self-assigned this Oct 18, 2023
@erikjv
Copy link
Collaborator Author

erikjv commented Oct 18, 2023

This still needs changelog entries

@erikjv erikjv force-pushed the work/load-translations-early branch from 90cd708 to 42a5a00 Compare October 18, 2023 14:28
@erikjv
Copy link
Collaborator Author

erikjv commented Oct 18, 2023

This still needs changelog entries

Done.

TheOneRing
TheOneRing reviewed Oct 26, 2023
View reviewed changes
src/gui/main.cpp Outdated Show resolved Hide resolved
@TheOneRing
Copy link
Member

@saw-jan I just realised the gui tests are relying on --confdir could you elaborate why?

@saw-jan
Copy link
Member

saw-jan commented Oct 26, 2023

@saw-jan I just realised the gui tests are relying on --confdir could you elaborate why?

yeah, we are using that option to use different config dir other than default one so that we don't mess up configs while running tests locally.

Fabian suggested if we can use XDG_CONFIG_HOME env during tests. so, we are going to try that one

@TheOneRing
Copy link
Member

@saw-jan I just realised the gui tests are relying on --confdir could you elaborate why?

yeah, we are using that option to use different config dir other than default one so that we don't mess up configs while running tests locally.

Fabian suggested if we can use XDG_CONFIG_HOME env during tests. so, we are going to try that one

thx can you prepare a pr? (please don't commit to this one)

@saw-jan
Copy link
Member

saw-jan commented Oct 26, 2023 •
edited

thx can you prepare a pr? (please don't commit to this one)

yeah, on the way

@saw-jan saw-jan mentioned this pull request Oct 26, 2023
Merged
@saw-jan
Copy link
Member

saw-jan commented Oct 26, 2023

yeah, on the way

PR is ready to be merged: #11316

@erikjv
Remove deprecated option --confdir
7f99f88 
This was meant to be used before roaming profiles were supported on
Windows.

Fixes: #11246
@erikjv
Do translation setup before command-line option parsing
552c0e3 
Now the messages during early start-up can be localized.

Fixes: #11142
@erikjv
Make command-line options and messages translatable
8b4766c
@erikjv erikjv force-pushed the work/load-translations-early branch from 40b1243 to 8b4766c Compare October 27, 2023 13:08
@TheOneRing TheOneRing enabled auto-merge (rebase) October 27, 2023 13:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit bbb63d8 into master Oct 27, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the work/load-translations-early branch October 27, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOneRing TheOneRing TheOneRing approved these changes

@fmoc fmoc Awaiting requested review from fmoc

Assignees

@erikjv erikjv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate legacy --confdir command-line argument Setup translations before Application instantiation
3 participants
@erikjv @TheOneRing @saw-jan