Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Update dialogs to the new modal widget experience #11617

Merged
merged 1 commit into from
May 22, 2024
Merged

Adopt Update dialogs to the new modal widget experience #11617

merged 1 commit into from
May 22, 2024

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Apr 25, 2024

Fixes: #11593

@erikjv erikjv self-assigned this Apr 25, 2024
@erikjv erikjv marked this pull request as draft April 25, 2024 16:56
@erikjv erikjv requested a review from TheOneRing April 25, 2024 16:56
@erikjv erikjv force-pushed the work/adopt-update-dialogs branch 2 times, most recently from 82d0c63 to 66e5494 Compare May 3, 2024 12:50
@erikjv erikjv marked this pull request as ready for review May 3, 2024 12:50
@erikjv
Copy link
Collaborator Author

erikjv commented May 3, 2024

New message box:

Screenshot 2024-05-03 at 14 57 17

@erikjv
Copy link
Collaborator Author

erikjv commented May 3, 2024

Update downloaded dialog:

Screenshot 2024-05-03 at 15 06 54

@TheOneRing
Copy link
Member

Hmm could we use the same icon, the app icon, for both?
Also I guess both should be centered and not aligned to top?

@erikjv erikjv force-pushed the work/adopt-update-dialogs branch from 66e5494 to 5fdd4fe Compare May 7, 2024 13:07
@erikjv
Copy link
Collaborator Author

erikjv commented May 7, 2024

New screenshots:

Screenshot 2024-05-07 at 16 47 41 Screenshot 2024-05-07 at 16 49 22

TheOneRing
TheOneRing requested changes May 8, 2024
View reviewed changes
Copy link
Member

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but please take a look on my comments.

@erikjv erikjv force-pushed the work/adopt-update-dialogs branch from 5fdd4fe to 8e30f1f Compare May 21, 2024 15:17
@erikjv erikjv requested a review from TheOneRing May 21, 2024 15:17
@TheOneRing TheOneRing merged commit 9b6350d into master May 22, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the work/adopt-update-dialogs branch May 22, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOneRing TheOneRing TheOneRing approved these changes

Assignees

@erikjv erikjv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt Update dialogs to the new modal widget experience
2 participants
@erikjv @TheOneRing