SyncEngine: Fix renaming a single file cause the "delete all file" popup #7215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm setting the milestone to 2.6 since it is probably a regression |
ckamm
reviewed
Jun 4, 2019
test/testallfilesdeleted.cpp
Outdated
| // rename it | ||
| fakeFolder.localModifier().rename("hello.txt", "goodbye.txt"); | ||
|
|
||
| // Now, aboutToRemoveAllFiles with down as a direction |
There was a problem hiding this comment.
You mean that it's not triggered, right?
ckamm
approved these changes
Jun 4, 2019
Possibly a regression, since the new discovery discovers rist the renamed files as removed Issue #7204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly a regression, since the new discovery discovers rist the renamed
files as removed
Issue #7204