Support for openid connect #7509
Conversation
|
From drone:
QRandomGenerator was added in Qt 5.10. I don't really want to add a fallback with the insecure |
Okay, works for me 👍 |
|
Make Qt 5.12 minimum requirement: #7521 |
|
@TheOneRing mind review/approving? |
| QString accessToken = json["access_token"].toString(); | ||
| if (jsonParseError.error != QJsonParseError::NoError || json.isEmpty()) { | ||
| // Invalid or empty JSON: Network error maybe? | ||
| qCWarning(lcHttpCredentials) << "Error while refreshing the token" << reply->errorString() << jsonData << jsonParseError.errorString(); |
There was a problem hiding this comment.
Is there any error state you need to set in some variable or return value?
There was a problem hiding this comment.
The idea is that the jobs get re-tried and will then process to the normal authentication method.
Yeah, maybe something better could be done, but we really don't want to disturb the user in this case anyway. This is not new code, it just got one more level of identation.
No description provided.