Ignore the desktop.ini file in every directory, not only in top dir. #8299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The comment |
|
The desktop.ini file only concerns the local Explorer. If you sync it and the "other" computer does have a different screen resolution for example, things mit go wrong. OneDrive also does not sync |
|
Imo, it should be always synced, but renamed to a safe name. E.g. desktop.ini._RENAMED |
TheOneRing
reviewed
Dec 14, 2020
src/csync/csync_exclude.cpp
Outdated
| @@ -201,8 +201,8 @@ static CSYNC_EXCLUDE_TYPE _csync_excluded_common(const QString &path, bool exclu | |||
| #endif | |||
|
|
|||
| /* We create a Desktop.ini on Windows for the sidebar icon, make sure we don't sync it. */ | |||
There was a problem hiding this comment.
The comment is now misleading.
TheOneRing
approved these changes
Dec 14, 2020
|
Internal ci issues are fixed on 2.7 and master |
dragotin
force-pushed
the
never_sync_desktop_ini
branch
from
57a11b4
to
7c20000
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8298 for reasons.