Make sure share names are in sync with server #8546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the name of a share link does not yield an error, but causes the server to automatically assign the link ID. The UI so far didn't show this, however. Rather than disallowing empty link names in the UI, we'll follow a "server makes it right" approach and trust it to either return an error or accept the request. In the latter case (which is what is experienced when emptying the name), to show up-to-date information client side, we have to re-fetch the share names from the server to show accurate information.
TheOneRing
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the name of a share link does not yield an error, but causes the server to automatically assign the link ID. The UI so far didn't show this, however. Rather than disallowing empty link names in the UI, we'll follow a "server makes it right" approach and trust it to either return an error or accept the request. In the latter case (which is what is experienced when emptying the name), to show up-to-date information client side, we have to re-fetch the share names from the server to show accurate information.
Fixes #7549.