Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show last sync date in tray menu #8547

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Show last sync date in tray menu #8547

merged 1 commit into from
Apr 15, 2021

Conversation

fmoc
Copy link
Contributor

@fmoc fmoc commented Apr 9, 2021 •
edited
Loading

Fixes #5644.

screenshot_2021-04-09_16-05-50

@fmoc fmoc requested a review from TheOneRing April 9, 2021 13:56
fmoc pushed a commit that referenced this pull request Apr 9, 2021
Add changelog entry for #5644/#8547
8318758
TheOneRing
TheOneRing reviewed Apr 12, 2021
View reviewed changes
src/gui/folderman.cpp Outdated Show resolved Hide resolved
TheOneRing
TheOneRing reviewed Apr 13, 2021
View reviewed changes
src/gui/folderman.h Outdated Show resolved Hide resolved
fmoc pushed a commit that referenced this pull request Apr 13, 2021
Add changelog entry for #5644/#8547
6e35c8f
@fmoc fmoc force-pushed the work/issue-5644 branch 3 times, most recently from 96c446d to 48a975f Compare April 13, 2021 15:15
@fmoc fmoc requested a review from TheOneRing April 14, 2021 10:31
@fmoc fmoc force-pushed the work/issue-5644 branch 2 times, most recently from 5762303 to fcca25e Compare April 15, 2021 14:26
@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing
Copy link
Member

Ship it, mac used to compile. I'll try to fix the cache somehow...

fmoc pushed a commit that referenced this pull request Apr 15, 2021
Add changelog entry for #5644/#8547
e810e5d
Display last sync date in context menu
208b037 
This way, the user can quickly see what "up to date" refers to.

In case the last sync was done on the same day, the date is hidden and
only the time is shown.
@fmoc fmoc merged commit ab110bc into master Apr 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/issue-5644 branch April 15, 2021 16:24
@jnweiger
Copy link
Contributor

tested with 2.9.0-beta3 on Linux Mint 20.2

My tray icon menu does not show a date. Instead it shows a useless "Syncing 0 of 0". When all Accounts are in "Sync succeded" state, as confirmed by clicking through all accounts and hovering over the icon.

image

Is this due to the new 'i' on blue circle, that the sync is not really considered as succeeded here?

@jnweiger jnweiger mentioned this pull request Aug 26, 2021
Closed
20 tasks
@TheOneRing
Copy link
Member

tested with 2.9.0-beta3 on Linux Mint 20.2

My tray icon menu does not show a date. Instead it shows a useless "Syncing 0 of 0". When all Accounts are in "Sync succeded" state, as confirmed by clicking through all accounts and hovering over the icon.

image

Is this due to the new 'i' on blue circle, that the sync is not really considered as succeeded here?

With the ignored state it should tell you n files ignored

@jnweiger jnweiger mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOneRing TheOneRing TheOneRing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tray menu: Clarify "Up to date" item with time of last E-Tag check
3 participants
@fmoc @TheOneRing @jnweiger