Explicitly set the layout direction if changing the locale #8981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjv
approved these changes
Sep 8, 2021
| @@ -758,6 +758,8 @@ void Application::setupTranslations() | |||
| QLocale newLocale(lang); | |||
| qCDebug(lcApplication) << "language" << lang << "was enforced, changing default locale to" << newLocale; | |||
| QLocale::setDefault(newLocale); | |||
| // setting the layout direction directly only appears to be needed on mac | |||
There was a problem hiding this comment.
IF this doesn't occur on 5.15, then I'd put it in an if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0)) statement.
TheOneRing
force-pushed
the
work/mac_rtl
branch
from
539e7fb
to
7966626
Compare
TheOneRing
force-pushed
the
work/mac_rtl
branch
from
7966626
to
8deecef
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you see side effects of the patch?
The issue does not occur with Qt 5.15 so maybe I should ifdef it
Fixes: #8806