Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix propagation of ignore list changes #9149

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Oct 14, 2021

Previously, when changing the ignore list, those changes would not be
propagated to existing sync folders. Only after restarting the client,
would these changes be applied.

Fixes: #8975

@erikjv erikjv force-pushed the work/fix-ignore-list-change-propagation branch from 960e0a1 to 78924bf Compare October 14, 2021 15:35
src/gui/folder.cpp Outdated Show resolved Hide resolved
@erikjv erikjv force-pushed the work/fix-ignore-list-change-propagation branch from 78924bf to ff44607 Compare October 15, 2021 12:31
Copy link
Member

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix the changelog

erikjv added a commit that referenced this pull request Oct 15, 2021
Previously, when changing the ignore list, those changes would not be
propagated to existing sync folders. Only after restarting the client,
would these changes be applied.

#8975
#9149
@erikjv erikjv force-pushed the work/fix-ignore-list-change-propagation branch from ff44607 to 4e393e1 Compare October 15, 2021 17:47
propagated to existing sync folders. Only after restarting the client,
would these changes be applied.

Fixes: #8975
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the full link to the issue.

erikjv added a commit that referenced this pull request Oct 20, 2021
Previously, when changing the ignore list, those changes would not be
propagated to existing sync folders. Only after restarting the client,
would these changes be applied.

#8975
#9149
@erikjv erikjv force-pushed the work/fix-ignore-list-change-propagation branch from 4e393e1 to 14e057e Compare October 20, 2021 14:06
erikjv added a commit that referenced this pull request Oct 20, 2021
Previously, when changing the ignore list, those changes would not be
propagated to existing sync folders. Only after restarting the client,
would these changes be applied.

#8975
#9149
@erikjv erikjv force-pushed the work/fix-ignore-list-change-propagation branch from 14e057e to 6ec8510 Compare October 20, 2021 14:06
erikjv added a commit that referenced this pull request Oct 20, 2021
Previously, when changing the ignore list, those changes would not be
propagated to existing sync folders. Only after restarting the client,
would these changes be applied.

#8975
#9149
@erikjv erikjv force-pushed the work/fix-ignore-list-change-propagation branch from 6ec8510 to 2bd74ea Compare October 20, 2021 14:08
@@ -0,0 +1,8 @@
Fix propagation of ignore list changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See changelog

erikjv added a commit that referenced this pull request Oct 20, 2021
Previously, when changing the ignore list, those changes would not be
propagated to existing sync folders. Only after restarting the client,
would these changes be applied.

#8975
#9149
@erikjv erikjv force-pushed the work/fix-ignore-list-change-propagation branch 2 times, most recently from c247bc6 to aa48091 Compare October 27, 2021 13:07
erikjv added a commit that referenced this pull request Oct 27, 2021
Previously, when changing the ignore list, those changes would not be
propagated to existing sync folders. Only after restarting the client,
would these changes be applied.

#8975
#9149
Previously, when changing the ignore list, those changes would not be
propagated to existing sync folders. Only after restarting the client,
would these changes be applied.

#8975
#9149
@erikjv erikjv force-pushed the work/fix-ignore-list-change-propagation branch from aa48091 to 8cc3dbc Compare October 27, 2021 14:00
@TheOneRing TheOneRing merged commit 4643fc7 into 2.9 Oct 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/fix-ignore-list-change-propagation branch October 27, 2021 14:20
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants