Ensure we only update the clients url after the sync was stopped #9202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/url_update
branch
from
51ace79
to
7415f4f
Compare
When the client detects a change of the url we ask the user to accept the change or if it was only representational change we directly accept the change. Due to a bug the we aborted the sync only after we updated the url. This caused the client to idle for one minute.
TheOneRing
force-pushed
the
work/url_update
branch
from
7415f4f
to
f6b849e
Compare
erikjv
approved these changes
Nov 10, 2021
|
Kudos, SonarCloud Quality Gate passed! |
TheOneRing
added a commit
that referenced
this pull request
Nov 10, 2021
When the client detects a change of the url we ask the user to accept the change or if it was only representational change we directly accept the change. Due to a bug the we aborted the sync only after we updated the url. This caused the client to idle for one minute. (cherry picked from commit 1aec61e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client detects a change of the url we ask the user to accept
the change or if it was only representational change we directly accept the change.
Due to a bug the we aborted the sync only after we updated the url.
This caused the client to idle for one minute.