Windows: Block system shutdown until we are properly shutdown #9227
Conversation
TheOneRing
force-pushed
the
work/block
branch
from
4c7bb92
to
989d2a8
Compare
|
We now block for up to 5s, if we take longer we might get killed by the system. We could also use ShutdownBlockReasonCreate |
TheOneRing
force-pushed
the
work/block
branch
from
989d2a8
to
2136bee
Compare
TheOneRing
force-pushed
the
work/block
branch
from
2136bee
to
c8e3468
Compare
| @@ -2,6 +2,10 @@ include(ECMAddAppIcon) | |||
|
|
|||
| find_package(Qt5 REQUIRED COMPONENTS Widgets) | |||
|
|
|||
| #if (WIN32) | |||
There was a problem hiding this comment.
If this is an optional dependency, consider introducing a CMake variable allowing users to opt into adding it. Could also be used in the code to opt into setting that icon.
There was a problem hiding this comment.
I don't consider it optional.
Optional dependencies never solved an issue, optional Qt modules certainly never did that.
| OC_ASSERT(RegisterClass(&wc)); | ||
|
|
||
| auto window = CreateWindowW(wc.lpszClassName, L"watcher", WS_OVERLAPPED, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, nullptr, nullptr, wc.hInstance, nullptr); | ||
| OC_ASSERT_X(window, Utility::formatWinError(GetLastError()).toUtf8().constData()); | ||
| auto watcherWindow = CreateWindowW(wc.lpszClassName, reinterpret_cast<const wchar_t *>(Theme::instance()->appNameGUI().utf16()), |
There was a problem hiding this comment.
You need the app name more than once. Might be easier to create a variable for it.
There was a problem hiding this comment.
Different scopes, and the lambda can't capture anything.
TheOneRing
force-pushed
the
work/block
branch
from
c8e3468
to
a6c5a85
Compare
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.