Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the creation of the icon to the main thread to prevent crash #9418

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Move the creation of the icon to the main thread to prevent crash #9418

merged 1 commit into from
Feb 4, 2022

Conversation

TheOneRing
Copy link
Member

@TheOneRing TheOneRing commented Feb 3, 2022 •
edited
Loading

We also ensure that qApp is completely set up when we create the icon.

Fixes: #9417

@TheOneRing
Move the creation of the icon to the main thread to prevent crash
a652e07 
We also ensure that qApp is completely set up when we create the icon.
@TheOneRing TheOneRing added this to the 2.10.1 milestone Feb 3, 2022
@TheOneRing TheOneRing requested a review from a team February 3, 2022 09:45
@TheOneRing TheOneRing mentioned this pull request Feb 3, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit 601fc81 into 2.10 Feb 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/9417 branch February 4, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjv erikjv erikjv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheOneRing @erikjv