Bugfix: add open local/remote folder options #9420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjv
force-pushed
the
work/fix-opening-folders
branch
from
416252c
to
b9fa51d
Compare
TheOneRing
reviewed
Feb 4, 2022
src/gui/accountsettings.cpp
Outdated
| auto info = _model->infoForIndex(index); | ||
| OC_ASSERT(info); | ||
| if (auto info = _model->infoForIndex(index)) { | ||
| QAction *ac = menu->addAction(tr("Open Remote Folder in Browser")); |
There was a problem hiding this comment.
see addAction(openLocallyLabel, this, []{
There was a problem hiding this comment.
Hmm, I wanted to make it clear that it's the remote folder that's being opened. But maybe that's too obvious. What do you think?
There was a problem hiding this comment.
Yes but what is a remote folder :D
and we should align it with the others.
TheOneRing
reviewed
Feb 4, 2022
src/gui/accountsettings.cpp
Outdated
| auto info = _model->infoForIndex(index); | ||
| OC_ASSERT(info); | ||
| if (auto info = _model->infoForIndex(index)) { | ||
| QAction *ac = menu->addAction(tr("Open Remote Folder in Browser")); | ||
| QString path = info->_folder->remotePathTrailingSlash(); | ||
| path += info->_path; |
There was a problem hiding this comment.
for the root folder this results in //
There was a problem hiding this comment.
No, remotePathTrailingSlash() only appends the slash if there isn't already a trailing slash.
There was a problem hiding this comment.
yes but info->_path will be /
erikjv
force-pushed
the
work/fix-opening-folders
branch
2 times, most recently
from
7268a82
to
1ae5944
Compare
Add the "open local/remote folder" context menu items for non-sync-root items back into the accounts tab in the settings dialog. #9405
erikjv
force-pushed
the
work/fix-opening-folders
branch
from
1ae5944
to
90af240
Compare
TheOneRing
approved these changes
Feb 10, 2022
|
Kudos, SonarCloud Quality Gate passed! |
erikjv
added a commit
that referenced
this pull request
Feb 10, 2022
TheOneRing
pushed a commit
that referenced
this pull request
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the "open local/remote folder" context menu items for non-sync-root
items back into the accounts tab in the settings dialog.
#9405